Support parsing for multiline string #184
Conversation
BOOMeranGG
changed the title
|
@NightEule5 you will get conflicts with this one PR, I guess… 🥲 |
Ok with me |
...commonTest/kotlin/com/akuleshov7/ktoml/decoders/multiline/BasicMultilineStringDecoderTest.kt
Outdated
Show resolved
Hide resolved
|
Nothing else to add, looks good to me. We'll see what akuleshov7 thinks, parsing is more his thing |
| } else { | ||
| TomlLiteralString(this, lineNo, config) | ||
| } | ||
| '\'' -> TomlLiteralString(this, lineNo, config) | ||
| // ===== basic strings | ||
| '\"' -> TomlBasicString(this, lineNo) |
There was a problem hiding this comment.
So we received a multiline string and are parsing it with TomlBasicString?
It's ok, if it's not a mistake, but while reading the code - I would expect here different types of strings that start from ": Basic, Multiline, etc.
As this code was intended to be an entry point for determination of different types. So I got a little bit confused.
| @@ -43,19 +46,25 @@ public class TomlBasicString internal constructor( | |||
| public companion object { | |||
| private fun String.verifyAndTrimQuotes(lineNo: Int): Any = | |||
| when { | |||
| // ====== multiline string (""") ======= | |||
There was a problem hiding this comment.
Yeah, I see: you decided not to make differences on the higher level.
That's actually okay, may I should have done the same with LiteralStrings
| } | ||
| val value = line.substring(firstEqualsSign + 1).trim() | ||
|
|
||
| return value.startsWith("[") && | ||
| value.endsWith("]").not() | ||
| if (value.startsWith("[") && !value.endsWith("]")) { |
There was a problem hiding this comment.
the only stylistic comment I have here - is usage of when statement
return when {
value.startsWith("\"\"\"") && value.getCountOfOccurrencesOfSubstring("\"\"\"") == 1 ->
value.startsWith("'''") && value.getCountOfOccurrencesOfSubstring("\'\'\'") == 1 ->
}
It usually looks much better with a huge number of if statements.
But basically not important
Fixes #46