Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Levenshtein distance calculation for the enhancement of the 'invalid enum' error #232

Merged
merged 2 commits into from
Jun 18, 2023

Conversation

orchestr7
Copy link
Owner

What's done:

  • Inspired by Diktat: in most configuration files, we use enums, and authors of libraries working with these configuration files would like to assist users in identifying any misprints and suggesting the closest valid values
  • Actually I believe that this functionality should be implemented in all decoding libraries

### What's done:
- Inspired by diktat: in mostly each and every configuration files we have enums and authors of libraries that work with this configuration file would like to help users to find a misprint and suggest the closest value
- we think that this should be done on the side of all decoding libraries
@orchestr7 orchestr7 linked an issue Jun 17, 2023 that may be closed by this pull request
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ktlint found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

### What's done:
- Inspired by diktat: in mostly each and every configuration files we have enums and authors of libraries that work with this configuration file would like to help users to find a misprint and suggest the closest value
- we think that this should be done on the side of all decoding libraries
@orchestr7 orchestr7 merged commit 873ce99 into main Jun 18, 2023
@orchestr7 orchestr7 deleted the feature/levenshtein branch June 18, 2023 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add extra logic for validating enum values
1 participant