Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add encoding value classes #238

Merged
merged 2 commits into from
Sep 1, 2023
Merged

Add encoding value classes #238

merged 2 commits into from
Sep 1, 2023

Conversation

BOOMeranGG
Copy link
Collaborator

Fix #237

Please read the test cases carefully. I took some of them from docs. We shouldn't handle value classes as data classes, so I wrote encoding looking at Json serializer.


@Serializable
@JvmInline
value class AnotherInfoWrapper(val info: Info)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, even nested value classes work, great!

Copy link
Owner

@orchestr7 orchestr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you so much

@BOOMeranGG BOOMeranGG merged commit 8db0064 into main Sep 1, 2023
@BOOMeranGG BOOMeranGG deleted the support-value-class branch September 1, 2023 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: support value classes
2 participants