Merge branch '8.23.x' into 9.0.x

orchestral · Apr 5, 2024 · a34ca95 · a34ca95
2 parents 1cc009e + 84f91d3
commit a34ca95
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/CHANGELOG-8.x.md b/CHANGELOG-8.x.md
@@ -2,6 +2,14 @@
 
 This changelog references the relevant changes (bug and security fixes) done to `orchestra/testbench-core`.
 
+## 8.23.6
+
+Released: 2024-04-05
+
+### Fixes
+
+* Fixes `runningInUnitTests()` returning `true` when not running tests via Testbench CLI.
+
 ## 8.23.5
 
 Released: 2024-03-25

diff --git a/src/Console/Commander.php b/src/Console/Commander.php
@@ -101,7 +101,7 @@ public function handle(): void
             $laravel = $this->laravel();
             $kernel = $laravel->make(ConsoleKernel::class);
 
-            if (Env::has('TESTBENCH_PACKAGE_TESTER') === false && $laravel->runningUnitTests()) {
+            if (Env::has('TESTBENCH_PACKAGE_TESTER') === false && $laravel->runningUnitTests() === true) {
                 $laravel->instance('env', 'workbench');
             }