Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My build for Horizon with Symfony 5 support was failing because Composer believes atm that 5.0.x-dev targets the 4.x branch because of the current branch alias.
https://travis-ci.org/laravel/horizon/jobs/616761151
I've updated it to the correct branch alias as well by setting it to
4.x-dev
because that's the proper notation. Otherwise Composer believes this branch only holds patch releases. We did the same change for the framework and we're also rolling it out on the other first party libraries.testbench-core also needs to be updated with this as well as both master branches of the repos: https://github.com/orchestral/testbench-core/blob/4.x/composer.json#L47