Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update branch alias #255

Closed
wants to merge 1 commit into from
Closed

Update branch alias #255

wants to merge 1 commit into from

Conversation

driesvints
Copy link
Contributor

My build for Horizon with Symfony 5 support was failing because Composer believes atm that 5.0.x-dev targets the 4.x branch because of the current branch alias.

https://travis-ci.org/laravel/horizon/jobs/616761151

I've updated it to the correct branch alias as well by setting it to 4.x-dev because that's the proper notation. Otherwise Composer believes this branch only holds patch releases. We did the same change for the framework and we're also rolling it out on the other first party libraries.

testbench-core also needs to be updated with this as well as both master branches of the repos: https://github.com/orchestral/testbench-core/blob/4.x/composer.json#L47

@crynobone
Copy link
Member

Screenshot 2019-11-26 at 4 41 34 PM

I think you need to update your .travis.yml and remove Laravel 6.

As for Laravel 7, it related to deprecated class in Laravel.

@crynobone crynobone closed this Nov 26, 2019
@driesvints
Copy link
Contributor Author

@crynobone you're correct! Thanks for spotting that.

Nevertheless this should definitely be merged as well as the other notes I mentioned. I'm not sure why you believe this PR shouldn't be merged?

@crynobone
Copy link
Member

I'm not sure why you believe this PR shouldn't be merged?

As far as I know, there no affect since master branch composer.json will override any other branch aliasing.

@driesvints
Copy link
Contributor Author

@crynobone this is for the 4.x branch.

@crynobone
Copy link
Member

crynobone commented Nov 26, 2019

Yes, because master branch will override everything else. I can put "dev-master": "3.x-dev" in 4.x branch and packagist still ignored it.


The alias must be a comparable dev version, and the branch-alias must be present on the branch that it references. For dev-master, you need to commit it on the master branch.

https://getcomposer.org/doc/articles/aliases.md#branch-alias

@driesvints
Copy link
Contributor Author

@crynobone okay, I just thought you wanted to fix this because it's a bit weird to see the 5.0 alias on the 4.x branch but your call :)

@crynobone
Copy link
Member

Nah, I be wasting time updating all the branches that I maintain just for this every 6 months.

@driesvints driesvints deleted the patch-2 branch November 26, 2019 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants