Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up JSON; partial loading of JSON query results in React #2

Merged
merged 2 commits into from
Jan 9, 2024

Conversation

wtfiwtz
Copy link

@wtfiwtz wtfiwtz commented Jan 9, 2024

What type of PR is this?

  • Refactor
  • Feature
  • Bug Fix
  • New Query Runner (Data Source)
  • New Alert Destination
  • Other - Fork

Description

How is this tested?

  • Unit tests (pytest, jest)
  • E2E Tests (Cypress)
  • Manually
  • N/A

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

1. Compression of whitespace (3Mb => 2.6Mb)
2. Split JSON into partial results
// (before the full query result is available).
// This should be done sparingly - see https://react.dev/reference/react-dom/flushSync

// flushSync(() => {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could clean up the commented-out code

@wtfiwtz wtfiwtz merged commit 21faf54 into release/10.1.0 Jan 9, 2024
@wtfiwtz wtfiwtz deleted the improve-query-json-perf branch January 9, 2024 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants