Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Lazy-loaded providers of sub menu components are lost #6

Open
gund opened this issue Mar 22, 2019 · 0 comments · May be fixed by #7
Open

[Bug] Lazy-loaded providers of sub menu components are lost #6

gund opened this issue Mar 22, 2019 · 0 comments · May be fixed by #7
Assignees
@gund
Labels
bug Something isn't working

Comments

@gund
Copy link
Member

gund commented Mar 22, 2019

As the DI token that keeps a map of sub menu components registered in root module it will not pickup provided values from lazy loaded modules as they will have their own module injector.

The solution is to refresh value from DI token once lazy-loaded module has been loaded.
@gund gund added the bug Something isn't working label Mar 22, 2019
@gund gund self-assigned this Mar 22, 2019
@gund gund linked a pull request Mar 23, 2019 that will close this issue
Open
gund added a commit that referenced this issue Apr 16, 2019
@gund
feat(menu): allow to lazy-load sub header components mapping
cccb291 
re #6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gund gund

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fix] Lazy DI tokens orchestratora/ngx-dynamic-menu
1 participant
@gund