Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add preview subcommand #1089

Merged
merged 19 commits into from
Dec 30, 2022
Merged

Add preview subcommand #1089

merged 19 commits into from
Dec 30, 2022

Conversation

casey
Copy link
Collaborator

@casey casey commented Dec 25, 2022 •
edited
Loading

The test is slow, so I put it behind #[ignore].

@casey casey linked an issue Dec 29, 2022 that may be closed by this pull request
Add ability to preview inscriptions before publishing #1040
Closed
@casey casey marked this pull request as ready for review December 30, 2022 02:23
@casey casey requested a review from raphjaph December 30, 2022 02:23
@casey casey changed the title Start working on examples subcommand Add preview subcommand Dec 30, 2022
raphjaph
raphjaph approved these changes Dec 30, 2022
View reviewed changes
Copy link
Collaborator

@raphjaph raphjaph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand this correctly sandboxing restricts what is executed on ordinals.com inside the iframe but if I click into the /content endpoint the execution of the script is allowed because of the unsafe-inline and unsafe-eval.

@casey
Copy link
Collaborator Author

casey commented Dec 30, 2022

Which example are you referring to?

@casey casey enabled auto-merge (squash) December 30, 2022 17:47
@casey casey merged commit 5416093 into master Dec 30, 2022
@casey casey deleted the examples branch December 30, 2022 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raphjaph raphjaph raphjaph approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ability to preview inscriptions before publishing
2 participants
@casey @raphjaph