Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove wrapping on text inscriptions #1100

Merged
merged 2 commits into from
Dec 27, 2022
Merged

Remove wrapping on text inscriptions #1100

merged 2 commits into from
Dec 27, 2022

Conversation

casey
Copy link
Collaborator

@casey casey commented Dec 27, 2022

This improves the look of text without hard line wraps, but makes text with hard line wraps look much worse, so I think we should remove it.

We should encourage inscription authors to use HTML or markdown if they don't want hard line breaks. Since omitting all tags is allowed in html, you can publish just the text, no need for <html> or anything else.

Before

Screen Shot 2022-12-26 at 4 07 55 PM

After

Screen Shot 2022-12-26 at 4 13 25 PM

@casey casey requested a review from raphjaph December 27, 2022 00:12
@casey casey enabled auto-merge (squash) December 27, 2022 22:15
@casey casey disabled auto-merge December 27, 2022 22:17
@casey casey enabled auto-merge (squash) December 27, 2022 22:17
@casey casey merged commit 2f7304b into master Dec 27, 2022
@casey casey deleted the un-wrap-pre branch December 27, 2022 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants