Unrecognized even fields render inscriptions invalid #1107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphjaph
reviewed
Dec 29, 2022
| for tag in fields.keys() { | ||
| if let Some(lsb) = tag.first() { | ||
| if lsb % 2 == 0 { | ||
| return Err(InscriptionError::UnrecognizedEvenField); |
There was a problem hiding this comment.
So non-breaking changes cause an InscriptionError?
raphjaph
requested changes
Dec 29, 2022
raphjaph
approved these changes
Dec 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1046. This doesn't add a version, but allows us to add one in the future. We can add a version field with an even tag, which will render it invalid for old clients, allowing for future upgrades.