Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make PageHtml generic over PageContent type #1123

Merged
merged 2 commits into from
Dec 30, 2022
Merged

Make PageHtml generic over PageContent type #1123

merged 2 commits into from
Dec 30, 2022

Conversation

casey
Copy link
Collaborator

@casey casey commented Dec 30, 2022

Might as well, now that Boilerplate works with generics

@casey casey requested a review from raphjaph December 30, 2022 07:24
raphjaph
raphjaph approved these changes Dec 30, 2022
View reviewed changes
Copy link
Collaborator

@raphjaph raphjaph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@casey casey merged commit 8895f62 into master Dec 30, 2022
@casey casey deleted the page-html-generic branch December 30, 2022 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raphjaph raphjaph raphjaph approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@casey @raphjaph