Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fee-spent but unlost inscriptions #1125

Merged
merged 5 commits into from
Jan 2, 2023
Merged

Fee-spent but unlost inscriptions #1125

merged 5 commits into from
Jan 2, 2023

Conversation

casey
Copy link
Collaborator

@casey casey commented Dec 30, 2022

@raphjaph This is a truly horrific PR, but I wrote a bunch of tests and tested it from a few angles and I think it works.

This does a few things:

  • Tracks inscriptions that are spent to fees
  • Tracks inscriptions that are spent to fees that are then underpaid (thus destroying the sat). These have their locations updated to a satpoint consisting of a null outpoint, with an offset which increments as sats are lost
  • Tracks rare sats that are spent to fees

@casey casey linked an issue Dec 30, 2022 that may be closed by this pull request
@casey casey changed the title Track fee-spent inscriptions Fee-spent but unlost inscriptions Dec 30, 2022
@casey casey marked this pull request as ready for review December 31, 2022 07:01
@casey casey requested a review from raphjaph December 31, 2022 07:05
@casey casey merged commit 3904736 into master Jan 2, 2023
@casey casey deleted the flotsam-and-jetsam branch January 2, 2023 19:22
@casey casey mentioned this pull request Jan 5, 2023
@chendatony31
Copy link
Contributor

Hi @casey, do you have a block number example that meets the condition Tracks inscriptions that are spent to fees that are then underpaid (thus destroying the sat). These have their locations updated to a satpoint consisting of a null outpoint, with an offset which increments as sats are lost

@chendatony31
Copy link
Contributor

Is destroying the sat or lost sat mean the coinbase transaction didn't pay all of the fees and reward to the miner?

@chendatony31 chendatony31 mentioned this pull request May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Track fee-spent inscriptions
2 participants