Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output inscription ID from ord wallet inscribe #1208

Merged
merged 8 commits into from
Jan 12, 2023
Merged

Conversation

casey
Copy link
Collaborator

@casey casey commented Jan 12, 2023

No description provided.

tests/server.rs Outdated
@@ -185,12 +162,12 @@ fn inscription_content() {

rpc_server.mine_blocks(1);

let inscription_id = create_inscription(&rpc_server, "foo.txt");
let output = inscribe(&rpc_server);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use refutable pattern

tests/server.rs Outdated
}

#[test]
fn home_page_includes_latest_inscriptions() {
let rpc_server = test_bitcoincore_rpc::spawn();
create_wallet(&rpc_server);

let inscription_id = create_inscription(&rpc_server, "foo.png");
let output = inscribe(&rpc_server);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use refutable pattern

tests/server.rs Outdated
}

#[test]
fn home_page_includes_latest_inscriptions() {
let rpc_server = test_bitcoincore_rpc::spawn();
create_wallet(&rpc_server);

let inscription_id = create_inscription(&rpc_server, "foo.png");
let output = inscribe(&rpc_server);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
let output = inscribe(&rpc_server);
let Inscribe { inscription, .. } = inscribe(&rpc_server);

@casey casey enabled auto-merge (squash) January 12, 2023 23:14
@casey casey merged commit bcce994 into master Jan 12, 2023
@casey casey deleted the print-inscription-id branch January 12, 2023 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants