Enable Passphrase for Restore Command #1669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphjaph
requested changes
Feb 13, 2023
|
I've already done the create command changes, but have not implemented unit tests. Will try to get my work committed tonight or tomorrow on this. |
raphjaph
reviewed
Feb 17, 2023
raphjaph
reviewed
Feb 17, 2023
raphjaph
reviewed
Feb 17, 2023
src/subcommand/wallet/create.rs
Outdated
| rand::thread_rng().fill_bytes(&mut entropy); | ||
| #[derive(Debug, Parser)] | ||
| pub(crate) struct Create { | ||
| #[clap(long, default_value = "", help = "Use <PASSPHRASE> to derive wallet seed.")] |
There was a problem hiding this comment.
We are using the specific language of BIP 39 here.
raphjaph
reviewed
Feb 17, 2023
raphjaph
reviewed
Feb 17, 2023
raphjaph
approved these changes
Feb 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements an option to pass a passphrase when restoring from mnemonic.
Related Issue
Closes #1671
Motivation and Context
Without this change users are only able to (easily) import a wallet from Sparrow if they did NOT use a passphrase.
How Has This Been Tested?
Default case has been verified to call to_seed() with no passphrase and all single word data passed with the option is verified to replace that. Utilizes the standardized behavior as seen in other sub-commands.