Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for binary GLTF inscriptions #1689

Merged
merged 1 commit into from
Feb 12, 2023
Merged

Add support for binary GLTF inscriptions #1689

merged 1 commit into from
Feb 12, 2023

Conversation

casey
Copy link
Collaborator

@casey casey commented Feb 11, 2023

No description provided.

casey
casey commented Feb 12, 2023
View reviewed changes
Copy link
Collaborator Author

@casey casey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THE ORDICORD APPROVES

@casey casey merged commit 90411e2 into master Feb 12, 2023
@casey casey deleted the gltf-binary branch February 12, 2023 05:20
Psifour
Psifour approved these changes Feb 12, 2023
View reviewed changes
Copy link
Contributor

@Psifour Psifour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validated MIME and file extension. Additional work may be necessary to implement specific view handling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Psifour Psifour Psifour approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@casey @Psifour