Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github workflow to build and push Docker images on tag #1752

Closed
wants to merge 3 commits into from

Conversation

nevets963
Copy link

When a Dockerfile is successfully merged (hopefully PR #1751), we can automate the build and push of the Docker image to Docker Hub.

This PR adds a GitHub workflow to automatically build amd64 and arm64 Docker images and push them to the Docker registry (with a tag, and to also push/update the latest image tag).

This PR is largely based on this: https://github.com/getumbrel/umbrel-manager/blob/fc823490591ea55e26734d144a0527fe9618166d/.github/workflows/on-tag.yml

You need to create the necessary Github secrets (for the Docker registry credentials): https://docs.github.com/en/actions/security-guides/encrypted-secrets#creating-encrypted-secrets-for-a-repository

These need to be created:

  • DOCKER_USERNAME
  • DOCKER_PASSWORD
  • DOCKER_HUB_USER

You can create a tag easily by following these instructions: https://stackoverflow.com/a/18223354
The workflow is setup to look for tags using semver. versioning which looks inline with the existing tags: https://github.com/casey/ord/tags

@nmfretz
Copy link

nmfretz commented Mar 13, 2023

@casey is there any interest in merging this + https://github.com/casey/ord/pull/1751 to make it easy for people to use official casey/ord docker images to run ord in different environments, OSs, etc?

@casey
Copy link
Collaborator

casey commented Nov 30, 2023

I want to wait until we have a minimal dockerfile, that people find useful, before starting to dive into docker compose, and adding more features.

We created a PR with a minimal Dockerfile, which still has issues: #2786

@casey casey closed this Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants