-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add parallel LMDB database implementation #177
Conversation
@terror I refactored things so it should be straightforward to add an lmdb database implementation, just turn on the |
I didn't see anything that jumped out at me as being clearly wrong. Do things like |
@terror I figured it out! Lmdb (like redb) only allows one writer at a time. Calling |
I added some more changes which make the empty_index test pass. Putting |
d20a625
to
d2b3c19
Compare
Refactor redb into a separate module, so we can add a parallel lmdb implementation. I don't think there's a strong reason to merge this as is, it's more of a starting point to add an lmdb database implementation. We don't need a trait, we just need to add an
lmdb_database.rs
source file containingDatabase
andWriteTransaction
with the same public functions.