Use the --fee-rate when sending an amount #1922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
March 12, 2023 21:20
…ll', and 'max'. * 'wallet send all' sends all available cardinals * 'wallet send max' maximizes the output by sending all cardinals that are worth more than they cost in fees to send
|
I think the workaround until this is merged is to set the default fee-rate in Bitcoin Core and to manually unlock UTXOs between 'ord wallet send' commands. A fix would be helpful since users may not know the workaround and to save time for those who do. @raphjaph Do you have a moment to review this? |
gmart7t2
force-pushed
the
improve-sending-cardinals
branch
3 times, most recently
from
648fc76
to
0fd0b29
Compare
raphjaph
previously requested changes
Jul 24, 2023
gmart7t2
force-pushed
the
improve-sending-cardinals
branch
from
75c2a89
to
0fd0b29
Compare
raphjaph
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"ord wallet send" requires the --fee-rate flag but ignores it when sending cardinals. This PR fixes that and also adds 2 new Outgoing types: 'all', and 'max':
'wallet send all' sends all available cardinals
'wallet send max' maximizes the output by sending all cardinals that are worth more than they cost in fees to send
Users want to be able to consolidate all their cardinals into a single utxo. These new modes make that easier.
Closes #1842 but there is still the issue that "wallet send" leaves the user's inscriptions locked, and fails to run a 2nd time because it fails when it tries to lock the already-locked inscriptions.