-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement provenance in the index #2353
Conversation
What's about end point /parent to get metadata of parent inside child @casey |
I'm not sure this is necessary. The parent is known to the inscriber at inscribe time, so they have and can use the parent's inscription ID and can use it in the child, no need to look it up from an API endpoint. |
@cypherpork I just finished this initial implementation of provenance, in case you want to test/review. |
So as far as I understand, we can only solve the 1-dimensional problem at the moment. The child will point to the parent, but the parent won't know who their child is |
@casey, thank you - I have spun it up and started testing/reviewing. I will come back with notes in a day or two. |
And, note that there's a change to the implementation: #2278 (comment) |
Okay, changed the implementation back to use the variable length encoding for the index. It's not a big savings on its own, but if we have a few savings like these they add up. |
@casey can we do multiple parents with one child?
|
I'd like to enable this eventually, but it's not in the first version. What's the use case you're thinking of? |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v exciting!
This is an initial PR implementing draft spec for parent/child inscriptions. It only implements indexing parent inscriptions and displaying them on the front end and returning them from the JSON API.
Other features are not implemented and are deferred to a future PR: