Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arabic language for ordinal handbook #2442

Merged
merged 7 commits into from
Oct 13, 2023

Conversation

ordinaHO
Copy link
Contributor

@ordinaHO ordinaHO commented Sep 9, 2023

while serving on local , i had to add some script as you see so the language will display correctly and avoiding any errors! this one was kind of hard to do but will see how it goes
thanks in advance

ordinaHO and others added 5 commits September 9, 2023 23:01
while serving on local , i had to add some script as you see so the language will display correctly and avoiding any errors! this one was kind of hard to do but will see how it goes
@raphjaph
Copy link
Collaborator

raphjaph commented Oct 3, 2023

This looks good but can't really verify that everything is correct. Did you have someone proof-read it?

Also everything is right-aligned, which needs to be for Arabic, but if this looks good for people I'll just merge it.

Screenshot 2023-10-03 at 20 21 20

@ordinaHO
Copy link
Contributor Author

ordinaHO commented Oct 5, 2023

hey @raphjaph I went through multiple times and all should be correct and ofcours will need to update some details here and there ! currently im on vacation , however I will have acsses to my office next week before amesterdam conference to go through again .

Copy link
Collaborator

@raphjaph raphjaph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@raphjaph raphjaph enabled auto-merge (squash) October 13, 2023 14:26
@raphjaph raphjaph merged commit e54b75a into ordinals:master Oct 13, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants