Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix overflow in Sat::from_name #2500

Merged
merged 2 commits into from
Oct 9, 2023
Merged

Fix overflow in Sat::from_name #2500

merged 2 commits into from
Oct 9, 2023

Conversation

casey
Copy link
Collaborator

@casey casey commented Oct 6, 2023

Check after every digit if sat is out of range to avoid overflow.

@casey casey enabled auto-merge (squash) October 9, 2023 21:17
@casey casey merged commit c811d48 into ordinals:master Oct 9, 2023
6 checks passed
@casey casey deleted the fix-sat-from-name-overflow branch October 9, 2023 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raphjaph raphjaph raphjaph approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@casey @raphjaph