Allow inscribing a delegate without content #3027
Conversation
raphjaph
changed the title
* master: Dump and restore wallet from descriptors (ordinals#3048) Forbid destinations in same-sat mode (ordinals#3038) Enable JSON API by default (ordinals#3047) Exclude unnecessary docs (ordinals#3043) Add documentation for reinscriptions (ordinals#2963) Better wallet error messages (ordinals#3041) Remove uneccessary allocations in Inscription Script Creation (ordinals#3039) Test fee-spent inscription numbering (ordinals#3032) Break deploy recipes into multiple lines (ordinals#3026) Make wallet communicate with index via RPC (ordinals#2929)
There was a problem hiding this comment.
The overall logic of delegate should be that you can inscribe a delegate only with
ord wallet inscribe --delegate <INSCRIPTION_ID>
You may inscribe a delegate that doesn't exist with:
ord wallet inscribe --delegate <INSCRIPTION_ID> --allow-non-existant
And you can also inscribe a file in addition to both of these options as a fall back.
| @@ -108,6 +108,26 @@ impl Inscription { | |||
| }) | |||
| } | |||
|
|
|||
| pub(crate) fn without_file( | |||
There was a problem hiding this comment.
| pub(crate) fn without_file( | |
| pub(crate) fn delegate_only( |
| match (self.file, self.batch) { | ||
| (Some(file), None) => { | ||
| match (self.file, self.batch, self.delegate) { | ||
| (Some(file), None, _) => { |
There was a problem hiding this comment.
This would mean if we have a file and a delegate it would still inscribe the file. Same with the batch below. This should be tested.
| ensure! { | ||
| wallet.inscription_exists(delegate)?, | ||
| "delegate {delegate} does not exist" | ||
| } |
There was a problem hiding this comment.
Let's add a flag called --allow-non-existant-delegate and then skip this check if it is set.
There was a problem hiding this comment.
what is the expected response for non-existent-delegate w/o payload and existent-delegate w/ payload?
|
What's the status on this? |
|
Had worked around this when inscribing using batch delegate, I use a 1 byte dummy file so I can minimize the extra unnecessary cost and block space, hope this PR gets progress so I don't have to do that going forward, some markets make it think the ordinal is literally a 1 byte blank file when it should show the delegate content. |
This will allow using
wallet inscribewithout any batch or a file, resulting in smaller tx size.Todo: