Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sat related charms to /sat page #3340

Merged
merged 8 commits into from
Mar 23, 2024
Merged

Conversation

markovichecha
Copy link
Contributor

Added sat based charms to the /sat page. Resolves: #3030

Also made a minor tweak in forbid.sh to handle the silent failure when ripgrep is missing.

@markovichecha markovichecha changed the title feat: add sat related charms to /sat page Add sat related charms to /sat page Mar 22, 2024
@markovichecha
Copy link
Contributor Author

markovichecha commented Mar 22, 2024

@casey thanks for looking into PR, what are your thoughts on something like that instead of using u16? https://gist.github.com/markovichecha/03f491c990520bc5988175fdd2b0a11d

@casey casey enabled auto-merge (squash) March 23, 2024 00:09
@casey casey merged commit 35285d6 into ordinals:master Mar 23, 2024
5 checks passed
@casey
Copy link
Collaborator

casey commented Mar 23, 2024

Thanks for the PR! I changed some stuff, since I wanted to serialize Charms directly, instead of converting to strings, as well as add charm for the mythic sat, which didn't previously have one, because charms were only displayed for inscriptions.

@casey
Copy link
Collaborator

casey commented Mar 23, 2024

@casey thanks for looking into PR, what are your thoughts on something like that instead of using u16? https://gist.github.com/markovichecha/03f491c990520bc5988175fdd2b0a11d

This looks great, free free to open a PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add charms to /sat page
3 participants