-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unified table integration - testing branch please ignore #3913
Closed
Commits on Aug 18, 2024
-
partialord committed
Aug 18, 2024 Configuration menu - View commit details
-
Copy full SHA for 4006401 - Browse repository at this point
Copy the full SHA 4006401View commit details -
As far as I know, no one has ever used this, and it would take extra work to support it with the new OUTPOINT_TO_UTXO_ENTRY table (which greatly improves performance). Just remove the option for now.
partialord committedAug 18, 2024 Configuration menu - View commit details
-
Copy full SHA for 1821446 - Browse repository at this point
Copy the full SHA 1821446View commit details
Commits on Aug 19, 2024
-
remove redundant pointer handling in index_inscriptions()
This code is unused, now that we have the newer (and much nicer) pointer-handling code on lines 190-194.
partialord committedAug 19, 2024 Configuration menu - View commit details
-
Copy full SHA for dcb038a - Browse repository at this point
Copy the full SHA dcb038aView commit details -
unified OUTPOINT_TO_UTXO_ENTRY table
Replace the OUTPOINT_TO_TXOUT, OUTPOINT_TO_SAT_RANGES, and SATPOINT_TO_SEQUENCE_NUMBER tables with a new OUTPOINT_TO_UTXO_ENTRY table. This saves space by avoiding redundant key storage, and makes updates quicker since we can write all of an outpoint's data at once. It also simplifies caching. We used to have utxo_cache for OUTPOINT_TO_TXOUT and range_cache for OUTPOINT_TO_SAT_RANGES, while SATPOINT_TO_SEQUENCE_NUMBER was uncached; now, there's a single unified utxo_cache which covers all three. Additionally, since SCRIPT_PUBKEY_TO_OUTPOINT and SEQUENCE_NUMBER_TO_SATPOINT are storing data which is already included in the cache (just with the keys and values swapped), we get to cache those tables too for free. The combined effect is that an index with --index-sats and --index-addresses is now about 54 GB smaller and twice as fast to build.
partialord committedAug 19, 2024 Configuration menu - View commit details
-
Copy full SHA for fe558b3 - Browse repository at this point
Copy the full SHA fe558b3View commit details -
With the unified OUTPOINT_TO_UTXO_ENTRY table, these stats aren't useful; they're either identical to the stats in the regular "Committing at block height ..." message (if you're using --index-sats), or zero (if you're not).
partialord committedAug 19, 2024 Configuration menu - View commit details
-
Copy full SHA for 87a871e - Browse repository at this point
Copy the full SHA 87a871eView commit details
Commits on Aug 25, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 6ef1119 - Browse repository at this point
Copy the full SHA 6ef1119View commit details -
Configuration menu - View commit details
-
Copy full SHA for d694735 - Browse repository at this point
Copy the full SHA d694735View commit details -
Merge remote-tracking branch 'partialord/unified-table' into unified-…
…table-integration
Configuration menu - View commit details
-
Copy full SHA for 6043184 - Browse repository at this point
Copy the full SHA 6043184View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.