-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add identify command to wallet #586
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need test coverage for a few cases:
identify
shows zero ordinalsidentify
shows one ordinalidentify
shows two ordinalidentify
shows non-zero ordinal offset (to test offset handling)identify
doesn't show anything from output with only common ordinals
One integration tests to test command, the rest unit tests with a wrapper like this:
fn identify(utxo: Vec<Utxo>) -> Vec<(Ordinal, OutPoint, u64, Rarity> {
}
```
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, looks good! Only change would be to add an additional test which passes a two different UTXOs with two different outpoints, each with an uncommon ordinal, and makes sure that the right ordinal is associated with the right outpoint.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, LGTM!
No description provided.