Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rare.txt #619

Merged
merged 4 commits into from
Oct 4, 2022
Merged

Add rare.txt #619

merged 4 commits into from
Oct 4, 2022

Conversation

casey
Copy link
Collaborator

@casey casey commented Oct 4, 2022

No description provided.

@casey casey requested a review from raphjaph October 4, 2022 21:31
@casey casey marked this pull request as ready for review October 4, 2022 21:57
@casey
Copy link
Collaborator Author

casey commented Oct 4, 2022

I decided to go with ordinal\tsatpoint, for a few reasons:

  • The page is already huge, so adding additional data makes it even huger.
  • Everything else can be derived from ordinal and satpoint (we could create a google sheet that you can copy/paste the data into, and it would generate the extra tables)
  • Encoding two items in a redb value is a little annoying
  • Looking up the time for every rare ordinal transferred requires hitting the client, which might make indexing slower

@casey casey merged commit dd2729d into master Oct 4, 2022
@casey casey deleted the rare branch October 4, 2022 22:08
@casey
Copy link
Collaborator Author

casey commented Oct 4, 2022

@raphjaph Merging so I can start rebuilding the database now, but please take a look anyway!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raphjaph raphjaph Awaiting requested review from raphjaph

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@casey