Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check that transaction fees are reasonable #669

Merged
merged 6 commits into from
Oct 19, 2022
Merged

Check that transaction fees are reasonable #669

merged 6 commits into from
Oct 19, 2022

Conversation

casey
Copy link
Collaborator

@casey casey commented Oct 18, 2022

No description provided.

@casey casey marked this pull request as ready for review October 18, 2022 23:44
@casey casey requested a review from raphjaph October 18, 2022 23:44
@casey
Copy link
Collaborator Author

casey commented Oct 18, 2022

@raphjaph Take a look! I added a checks that target fee rates are equal to the target fee rate. This requires avoiding calling .build() before fees are added, since that will now panic, so I changed fee estimation to be done on a dummy transaction with null inputs, instead of calling self.build().

raphjaph
raphjaph approved these changes Oct 19, 2022
View reviewed changes
Copy link
Collaborator

@raphjaph raphjaph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@casey casey merged commit d9a050f into master Oct 19, 2022
@casey casey deleted the check-fees branch October 19, 2022 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raphjaph raphjaph raphjaph approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@casey @raphjaph