Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add helpers to make transaction builder tests more concise #679

Merged
merged 2 commits into from
Oct 20, 2022
Merged

Add helpers to make transaction builder tests more concise #679

merged 2 commits into from
Oct 20, 2022

Conversation

casey
Copy link
Collaborator

@casey casey commented Oct 20, 2022

I refactored the tests to use helper functions to generate outpoints, addresses, transaction inputs, and transaction outputs. This makes them way more compact and easier to read.

@casey casey requested a review from raphjaph October 20, 2022 04:32
@casey casey changed the title Add helper to make transaction builder tests more concise Add helpers to make transaction builder tests more concise Oct 20, 2022
raphjaph
raphjaph approved these changes Oct 20, 2022
View reviewed changes
Copy link
Collaborator

@raphjaph raphjaph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice and concise

@casey casey enabled auto-merge (squash) October 20, 2022 17:32
@casey casey merged commit e251af2 into master Oct 20, 2022
@casey casey deleted the condense-tests branch October 20, 2022 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raphjaph raphjaph raphjaph approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@casey @raphjaph