Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve progress bar #694

Merged
merged 2 commits into from
Oct 24, 2022
Merged

Improve progress bar #694

merged 2 commits into from
Oct 24, 2022

Conversation

casey
Copy link
Collaborator

@casey casey commented Oct 21, 2022

  • Set initial position correctly
  • Only increment if we're not done
  • If the position is greater than the length, update the length
  • Clear the progress bar once we're done

@casey
Improve progress bar
c162cab 
- Set initial position correctly
- Only increment if we're not done
- If the position is greater than the length, update the length
- Clear the progress bar once we're done
@casey casey requested a review from raphjaph October 21, 2022 19:48
@casey
Copy link
Collaborator Author

casey commented Oct 21, 2022

@raphjaph I think this is ready to go! It fixes a bunch of issues with the progress bar.

@casey casey linked an issue Oct 21, 2022 that may be closed by this pull request
Fix progress bar #695
Closed
@casey casey enabled auto-merge (squash) October 24, 2022 16:54
@casey casey merged commit 9c169d4 into master Oct 24, 2022
@casey casey deleted the progress-bar-improvements branch October 24, 2022 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raphjaph raphjaph raphjaph approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix progress bar
2 participants
@casey @raphjaph