Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only index ordinals if --index-ordinals is passed #837

Merged
merged 10 commits into from
Nov 24, 2022
Merged

Conversation

casey
Copy link
Collaborator

@casey casey commented Nov 24, 2022

Some concerns with leaving this stuff in place behind a flag:

  • extra subcommands in help (find, list, info)
  • updater becomes a little more complicated (not incredibly bad though)
  • have to maintain and test two configurations (for example, just have tests that exercise error messages when flag is not passed)

jk who cares, we can deal with those problems if and when they come up

@casey casey linked an issue Nov 24, 2022 that may be closed by this pull request
@casey casey merged commit 7e696ef into master Nov 24, 2022
@casey casey deleted the partial-index-default branch November 24, 2022 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nummerdämmerung
2 participants