allow inscribing without specifying satpoint #919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casey
requested changes
Dec 8, 2022
src/subcommand/wallet/inscribe.rs
Outdated
| @@ -70,6 +73,32 @@ impl Inscribe { | |||
| Ok(()) | |||
| } | |||
|
|
|||
| fn choose_satpoint( | |||
There was a problem hiding this comment.
Add tests for all three cases:
- Some
- None and blank UTXO is found
- None and blank UTXO is not found
casey
reviewed
Dec 8, 2022
src/subcommand/wallet/inscribe.rs
Outdated
Comment on lines
91
to
97
| let cardinal_utxos = utxos | ||
| .iter() | ||
| .map(|(outpoint, _)| *outpoint) | ||
| .filter(|outpoint| !inscribed_utxos.contains(outpoint)) | ||
| .collect::<Vec<OutPoint>>(); | ||
|
|
||
| match cardinal_utxos.first() { |
There was a problem hiding this comment.
Suggested change
| let cardinal_utxos = utxos | |
| .iter() | |
| .map(|(outpoint, _)| *outpoint) | |
| .filter(|outpoint| !inscribed_utxos.contains(outpoint)) | |
| .collect::<Vec<OutPoint>>(); | |
| match cardinal_utxos.first() { | |
| match utxos | |
| .iter() | |
| .map(|(outpoint, _)| *outpoint) | |
| .filter(|outpoint| !inscribed_utxos.contains(outpoint)).next() { |
casey
reviewed
Dec 8, 2022
src/subcommand/wallet/inscribe.rs
Outdated
Comment on lines
91
to
101
| match utxos | ||
| .iter() | ||
| .map(|(outpoint, _)| *outpoint) | ||
| .find(|outpoint| !inscribed_utxos.contains(outpoint)) | ||
| { | ||
| Some(outpoint) => SatPoint { | ||
| outpoint, | ||
| offset: 0, | ||
| }, | ||
| None => return Err(anyhow!("wallet contains no cardinal utxos")), | ||
| } |
There was a problem hiding this comment.
Suggested change
| match utxos | |
| .iter() | |
| .map(|(outpoint, _)| *outpoint) | |
| .find(|outpoint| !inscribed_utxos.contains(outpoint)) | |
| { | |
| Some(outpoint) => SatPoint { | |
| outpoint, | |
| offset: 0, | |
| }, | |
| None => return Err(anyhow!("wallet contains no cardinal utxos")), | |
| } | |
| utxos | |
| .iter() | |
| .map(|(outpoint, _)| *outpoint) | |
| .find(|outpoint| !inscribed_utxos.contains(outpoint)) | |
| .map(|outpoint| SatPoint { | |
| outpoint, | |
| offset: 0, | |
| }) | |
| .ok_or_else(|| anyhow!("wallet contains no cardinal utxos"))? |
casey
approved these changes
Dec 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #905