Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(minor): Fix incorrect syscalls #187

Merged
merged 5 commits into from
Sep 14, 2023
Merged

fix(minor): Fix incorrect syscalls #187

merged 5 commits into from
Sep 14, 2023

Conversation

hassila
Copy link
Contributor

@hassila hassila commented Sep 14, 2023

Description

Deducts the syscall overhead for cleaner statistics.
Fix the broken API for setup closures.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Minimal checklist:

  • I have performed a self-review of my own code
  • I have added DocC code-level documentation for any public interfaces exported by the package
  • I have added unit and/or integration tests that prove my fix is effective or that my feature works

@hassila hassila requested review from dimlio and freef4ll September 14, 2023 09:12
@github-actions
Copy link
Contributor

github-actions bot commented Sep 14, 2023

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #187 (73f24f4) into main (1e3568b) will decrease coverage by 0.15%.
The diff coverage is 51.35%.

❗ Current head 73f24f4 differs from pull request most recent head d7b3cf5. Consider uploading reports for the commit d7b3cf5 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #187      +/-   ##
==========================================
- Coverage   71.14%   70.99%   -0.15%     
==========================================
  Files          29       29              
  Lines        3652     3671      +19     
==========================================
+ Hits         2598     2606       +8     
- Misses       1054     1065      +11     
Files Changed Coverage Δ
.../Benchmark/Benchmark+ConvenienceInitializers.swift 0.00% <0.00%> (ø)
Sources/Benchmark/Benchmark.swift 73.05% <ø> (ø)
Sources/Benchmark/BenchmarkExecutor.swift 93.77% <100.00%> (+0.16%) ⬆️
Sources/Benchmark/BenchmarkRunner.swift 59.09% <100.00%> (+0.10%) ⬆️
Files Changed Coverage Δ
.../Benchmark/Benchmark+ConvenienceInitializers.swift 0.00% <0.00%> (ø)
Sources/Benchmark/Benchmark.swift 73.05% <ø> (ø)
Sources/Benchmark/BenchmarkExecutor.swift 93.77% <100.00%> (+0.16%) ⬆️
Sources/Benchmark/BenchmarkRunner.swift 59.09% <100.00%> (+0.10%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e3568b...d7b3cf5. Read the comment docs.

@hassila hassila enabled auto-merge (squash) September 14, 2023 09:36
@hassila hassila merged commit 8e6ffd9 into main Sep 14, 2023
@hassila hassila deleted the fix-incorrect-syscalls branch December 20, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants