Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove unnecssary jemalloc queries #37

Merged
merged 9 commits into from
Oct 11, 2022
Merged

fix: Remove unnecssary jemalloc queries #37

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
958c507
Don't ask for malloc/system stats unless needed for benchmark
hassila Oct 11, 2022
9d94089
Merge branch 'main' into reduce-sampling
hassila Oct 11, 2022
4a3a10c
Only calculate stats when needed, decreases the overhead in the empty…
hassila Oct 11, 2022
393f366
Fix SwiftLint
hassila Oct 11, 2022
5897f9a
Fix SwiftLint
hassila Oct 11, 2022
f1a2893
Fix SwiftLint
hassila Oct 11, 2022
7ddc201
Remove unnecssary jemalloc queries
hassila Oct 11, 2022
cf436ea
Fix SwiftLint.
hassila Oct 11, 2022
7f71c76
Merge branch 'main' into remove-unnecssary-jemalloc-queries
hassila Oct 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 16 additions & 18 deletions Sources/BenchmarkSupport/MallocStats/MallocStatsProducer+jemalloc.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,12 @@ import jemalloc
public class MallocStatsProducer {
var threadCacheMIB: [Int]
var epochMIB: [Int]
var smallNMallocMIB: [Int]
var largeNMallocMIB: [Int]
var smallNDallocMIB: [Int]
var largeNDallocMIB: [Int]
var smallAlloctedMIB: [Int]
var largeAllocatedMIB: [Int]
// var smallNMallocMIB: [Int]
// var largeNMallocMIB: [Int]
// var smallNDallocMIB: [Int]
// var largeNDallocMIB: [Int]
// var smallAlloctedMIB: [Int]
// var largeAllocatedMIB: [Int]
var totalAllocatedMIB: [Int]
var smallTMallocMIB: [Int]
var largeTMallocMIB: [Int]
Expand Down Expand Up @@ -52,20 +52,18 @@ public class MallocStatsProducer {
return epoch
}

// swiftlint:disable function_body_length cyclomatic_complexity

// Basically just set up a number of cached MIB structures for
// more efficient queries later of malloc statistics.
public init() {
epochMIB = [size_t](repeating: 0, count: 1)
totalAllocatedMIB = [size_t](repeating: 0, count: 2)
threadCacheMIB = [size_t](repeating: 0, count: 3)
smallNMallocMIB = [size_t](repeating: 0, count: 5)
largeNMallocMIB = [size_t](repeating: 0, count: 5)
smallNDallocMIB = [size_t](repeating: 0, count: 5)
largeNDallocMIB = [size_t](repeating: 0, count: 5)
smallAlloctedMIB = [size_t](repeating: 0, count: 5)
largeAllocatedMIB = [size_t](repeating: 0, count: 5)
// smallNMallocMIB = [size_t](repeating: 0, count: 5)
// largeNMallocMIB = [size_t](repeating: 0, count: 5)
// smallNDallocMIB = [size_t](repeating: 0, count: 5)
// largeNDallocMIB = [size_t](repeating: 0, count: 5)
// smallAlloctedMIB = [size_t](repeating: 0, count: 5)
// largeAllocatedMIB = [size_t](repeating: 0, count: 5)
smallTMallocMIB = [size_t](repeating: 0, count: 5)
largeTMallocMIB = [size_t](repeating: 0, count: 5)

Expand All @@ -84,7 +82,7 @@ public class MallocStatsProducer {
print("mallctlnametomib epochMIB returned \(result)")
}
}

/*
mibSize = smallNMallocMIB.count
smallNMallocMIB.withUnsafeMutableBufferPointer { pointer in
let result = mallctlnametomib("stats.arenas.\(MALLCTL_ARENAS_ALL).small.nmalloc",
Expand All @@ -104,7 +102,7 @@ public class MallocStatsProducer {
print("mallctlnametomib largeNMallocMIB returned \(result)")
}
}

*/
// tcaches
mibSize = smallTMallocMIB.count
smallTMallocMIB.withUnsafeMutableBufferPointer { pointer in
Expand All @@ -125,7 +123,7 @@ public class MallocStatsProducer {
print("mallctlnametomib largeTMallocMIB returned \(result)")
}
}

/*
mibSize = smallNDallocMIB.count
smallNDallocMIB.withUnsafeMutableBufferPointer { pointer in
let result = mallctlnametomib("stats.arenas.\(MALLCTL_ARENAS_ALL).small.ndalloc",
Expand Down Expand Up @@ -165,7 +163,7 @@ public class MallocStatsProducer {
print("mallctlnametomib largeAllocatedMIB returned \(result)")
}
}

*/
mibSize = totalAllocatedMIB.count
totalAllocatedMIB.withUnsafeMutableBufferPointer { pointer in
let result = mallctlnametomib("stats.resident", pointer.baseAddress, &mibSize)
Expand Down