Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [sc-741] add helper for map with lock #22

Merged
merged 2 commits into from
Oct 11, 2022

Conversation

mr-swifter
Copy link
Contributor

Description

Include a summary of the change and which issue is fixed. Please also include relevant motivation and context.

Fixes Shortcut story [sc-issueNumber]

Squash merging will be used to merge into main (the commit message will be copied from PR text message)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Minimal checklist:

  • I have performed a self-review of my own code
  • I have added DocC code-level documentation for any public interfaces exported by the package
  • I have added unit and/or integration tests that prove my fix is effective or that my feature works

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #741: Map with lock helper.

@codecov
Copy link

codecov bot commented Oct 11, 2022

Codecov Report

Merging #22 (53ec288) into main (23c503f) will decrease coverage by 4.99%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #22      +/-   ##
==========================================
- Coverage   68.59%   63.59%   -4.99%     
==========================================
  Files           7        8       +1     
  Lines         191      206      +15     
==========================================
  Hits          131      131              
- Misses         60       75      +15     
Impacted Files Coverage Δ
Sources/ConcurrencyHelpers/MapWithLock.swift 0.00% <0.00%> (ø)
Impacted Files Coverage Δ
Sources/ConcurrencyHelpers/MapWithLock.swift 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23c503f...53ec288. Read the comment docs.

Copy link
Contributor

@hassila hassila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So…. Need to understand the intention - this structure would protect inserts/gets from the dictionary but will not protect the actual values - they are expected to be immutable in the map?

@mr-swifter mr-swifter merged commit 8ea4e80 into main Oct 11, 2022
@mr-swifter mr-swifter deleted the feature/sc-741/map-with-lock-helper branch October 11, 2022 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants