Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(patch): [sc-3285] Add makeStream() #57

Merged
merged 3 commits into from
Aug 31, 2023

Conversation

axelandersson
Copy link
Contributor

@axelandersson axelandersson commented Aug 30, 2023

Description

These two functions are currently in the frontend but probably belong here instead.

Also merged them into one function to match the proposal in https://github.com/apple/swift-evolution/blob/main/proposals/0388-async-stream-factory.md#detailed-design.

Fixes Shortcut story [sc-3285]

Squash merging will be used to merge into main (the commit message will be copied from PR text message)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Minimal checklist:

  • I have performed a self-review of my own code
  • I have added DocC code-level documentation for any public interfaces exported by the package
  • I have added unit and/or integration tests that prove my fix is effective or that my feature works

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #3285: Move helpers from frontend to ConcurrencyHelpers.

@axelandersson axelandersson marked this pull request as ready for review August 30, 2023 10:39
@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Merging #57 (329bdca) into main (4e6c808) will decrease coverage by 1.53%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #57      +/-   ##
==========================================
- Coverage   82.43%   80.91%   -1.53%     
==========================================
  Files          19       20       +1     
  Lines         649      660      +11     
==========================================
- Hits          535      534       -1     
- Misses        114      126      +12     
Files Changed Coverage Δ
Sources/Helpers/MakeStream.swift 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

Files Changed Coverage Δ
Sources/Helpers/MakeStream.swift 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e6c808...329bdca. Read the comment docs.

@axelandersson axelandersson changed the title feat(patch): [sc-3285] Add makeStream and makeSingleStream feat(patch): [sc-3285] Add makeStream() Aug 30, 2023
Copy link
Contributor

@hassila hassila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@axelandersson axelandersson merged commit 822701e into main Aug 31, 2023
@axelandersson axelandersson deleted the feature/sc-3285/asyncstream-helpers branch August 31, 2023 07:02
@dimlio
Copy link
Contributor

dimlio commented Aug 31, 2023

I think we should bump minor since a new API was added.
Made 2.1.0 and removed 2.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants