-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(patch): [sc-3285] Add makeStream() #57
Conversation
This pull request has been linked to Shortcut Story #3285: Move helpers from frontend to ConcurrencyHelpers. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #57 +/- ##
==========================================
- Coverage 82.43% 80.91% -1.53%
==========================================
Files 19 20 +1
Lines 649 660 +11
==========================================
- Hits 535 534 -1
- Misses 114 126 +12
... and 1 file with indirect coverage changes
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Swift 5.9 signature
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, this also closes:
https://app.shortcut.com/ordo-one/story/802/move-makestreamandcontinuation-to-concurrency-helpers
I think we should bump minor since a new API was added. |
Description
These two functions are currently in the frontend but probably belong here instead.
Also merged them into one function to match the proposal in https://github.com/apple/swift-evolution/blob/main/proposals/0388-async-stream-factory.md#detailed-design.
Fixes Shortcut story [sc-3285]
Squash merging will be used to merge into
main
(the commit message will be copied from PR text message)How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Minimal checklist:
DocC
code-level documentation for any public interfaces exported by the package