Fix VRCFeatures "Hide From Main View" also hiding in mirrors #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
I thought i literally fixed this recently 🤔 i even have a test scene/world set up for it and all that |
Owner
|
reading it all again seems like it is correct so I dont get how i got it wrong with all the testing I did 💀 |
Owner
|
yeah confirmed here, i dont get how i missed it 😓 |
Owner
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the VRCFeatures module, I think
bool isMainViewneeds to also check whether or not it is rendering in a mirror, otherwise hiding from main view also hides it from the mirror. I'm not 100% certain there isn't some logical reason you had it set up like that though that I'm just not thinking of.