Seperate monolithic Common project into individual subprojects.
#499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: roomfinder
TheGrayAlien
added a commit
to TheGrayAlien/DemeoMods
that referenced
this pull request
Sep 20, 2023
Seperate monolithic Common project into individual subprojects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #498.
Using "monolithic" in the title may be misleading, as there is only a single common component:
UI.So really, this is more of a rename of
Common->Common.UI, so that otherCommon.<something>projects can come along.Rather than use underscores to separate name parts (e.g.,
Common_UI), this PR opts for dots which is the .NET convention.This PR also deletes
Common/CommonModule.cs, which has gone unused.