Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix privacy toggle not capturing updated PCVR field. #514

Merged
merged 3 commits into from
Oct 2, 2023

Conversation

orendain
Copy link
Owner

@orendain orendain commented Oct 2, 2023

Fixes privacy toggle not capturing updated PCVR field.

The field must have been updated in Demeo at some point, as the current hook cannot be found.

Additionally, moved the methods to later in the file so that they are in order according to how they appear in the top Patch() method.

@orendain orendain self-assigned this Oct 2, 2023
@github-actions github-actions bot added the area: houserules/core The core framework for HouseRules label Oct 2, 2023
@orendain orendain added the type: bug Something isn't working and needs fixing. label Oct 2, 2023
@orendain orendain marked this pull request as ready for review October 2, 2023 06:21
@TheGrayAlien TheGrayAlien merged commit ff90e4b into main Oct 2, 2023
2 checks passed
@TheGrayAlien TheGrayAlien deleted the eo/fix-public branch October 2, 2023 08:22
TheGrayAlien pushed a commit that referenced this pull request Oct 3, 2023
#514 was incorrect. This PR
properly fixes the issue that PR was meant to.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: houserules/core The core framework for HouseRules type: bug Something isn't working and needs fixing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants