[Feat]: discard unsaved settings when settings modal is closed

[nbouvrette]

Expected Behavior

When I use showSettings, change something in the modal but don't save, if I re-open the modal I would expect to see the applicable settings (I would expect the modal to reset and show the right settings).

Current Behavior

When I use showSettings, change something in the modal but don't save, if I re-open the modal I see the unsaved settings which I find a confusing user experience.

Steps to reproduce

https://orestbida.com/demo-projects/cookieconsent/

1. Click "Show settings modal"
2. Change an option
3. Click on the "X" without saving
4. Click "Show settings modal"
5. The unsaved options are persisted

Proposed fix or additional info.

I suggest that the unsaved options are reset when closing the modal or re-opening the modal.

Version

latest

On which browser do you see the issue?

Chrome

[orestbida]

Sorry, this won't be worked on. This is the normal, expected behaviour rather than a bug.

[benseven]

Just wanted to flag that while this might be intended behaviour, it could lead to a situation where the user believes they have modified their settings to decline certain cookies, but behind the scenes that has not been saved and therefore blocking the scripts involved. If the modal doesn't reflect the currently applied settings when reopened, it's not a reliable interface in that regard, and I'd agree with the original filer of this issue that this is a UX bug. [But - thank you for a very helpful library nonetheless!]

…

On Wed, 15 Mar 2023 at 16:35, Orest Bida ***@***.***> wrote: Sorry, this won't be worked on. This is the normal, expected behaviour rather than a bug. — Reply to this email directly, view it on GitHub <#481 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AANAZC5HMUWWWVCLIUBGS6LW4HVTJANCNFSM6AAAAAAVNRSZGY> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[kevguy]

I noticed the same behavior as well when I'm working on adding a cookie banner with this to our application. And our lawyer said this is not cookie compliant. I'd suggest this should be re-opened.

[benseven]

I don’t believe it’s a legal compliance issue, it’s just that the settings window should always show the saved state unless it’s in the middle of being changed. And I think the difference in viewpoints here is coming from whether you consider a user in the middle of changing settings when the modal is closed and then reopened, or whether the act of closing it means you’ve lost unsaved changes. To me (and I think user testing would bear this out), if it’s closed without saving, it should revert to the recorded state. Otherwise, when it’s opened again (and being relied on as the way in which someone can change their settings as required under GDPR / UK-GDPR), its doesn’t show the user’s current settings but whatever config they were in the middle of. None of the legislation claims one thing or another about how the UI works, but the way this is being dismissed and then reopened while preserving an unsaved state is counterintuitive at best and misinforming users at worst. Again - a great tool but this is not a sensible default. Message ID: ***@***.***>

[orestbida]

Alright, I'll change the behavior since there are a few people who really care about it.

[orestbida]

This change will also affect v3.

[benseven]

Really appreciate you and your work. Thanks for looking at this again!

On Thu, 16 Mar 2023 at 16:32, Orest Bida ***@***.***> wrote: Alright, I'll change the behavior since there are a few people who really care about it. — Reply to this email directly, view it on GitHub <#481 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AANAZC24LIFDPK7POJHLD3TW4M6DXANCNFSM6AAAAAAVNRSZGY> . You are receiving this because you commented.Message ID: ***@***.***>

-- ben seven is a designer and web developer, the co-founder of http://kin.works and founder of https://devicelab.org *he frequently has to say 'no, sorry' to work or favours to focus on family and existing projects, and is grateful for your understanding.* +44 7746 200412 | ***@***.***

[nbouvrette]

Hey thanks guys - I was about to reply back with some UX references but I'm happy I won't have to worry about this one anymore!