Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: (v3) Duplicate id in <th> if multiple sections have cookieTable with same columns #483

Closed
EreMaijala opened this issue Mar 10, 2023 · 1 comment
Labels
bug:confirmed bug Something isn't working
Milestone

Comments

@EreMaijala
Copy link
Contributor

EreMaijala commented Mar 10, 2023

Expected Behavior

Table headers should have unique id attributes (or no id unless necessary)

Current Behavior

All th elements in the cookieTable get the id attribute from the header value (which could also make it invalid as an id) (see https://github.com/orestbida/cookieconsent/blob/v3.0-beta/src/core/modals/preferencesModal.js#L343). When there are more than one section with a table that has same header values, the id's get duplicated.

Steps to reproduce

  1. Use the included playground
  2. Duplicate Analytics Cookies section with a new title
  3. Open the Preferences window
  4. Observe duplicate id attributes in the cookie tables

Proposed fix or additional info.

No response

Version

3.0.0-rc13

On which browser do you see the issue?

Firefox, Chrome

@EreMaijala EreMaijala added the bug Something isn't working label Mar 10, 2023
@github-actions github-actions bot added the triage yet to be reviewed label Mar 10, 2023
@orestbida orestbida added bug:confirmed and removed triage yet to be reviewed labels Mar 14, 2023
@orestbida orestbida added this to the v3.0.0-rc.14 milestone Mar 14, 2023
orestbida added a commit that referenced this issue Mar 25, 2023
@orestbida
Copy link
Owner

fixed by c2623fb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug:confirmed bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants