Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: unchecked categories after closing/opening settings modal when consent is not valid #516

Closed
orestbida opened this issue May 12, 2023 · 0 comments · Fixed by #517
Closed

[Bug]: unchecked categories after closing/opening settings modal when consent is not valid #516

orestbida opened this issue May 12, 2023 · 0 comments · Fixed by #517
Labels
bug:confirmed bug Something isn't working
Milestone
v2.9.1

Comments

@orestbida
Copy link
Owner

orestbida commented May 12, 2023 •
edited
Loading

Expected Behavior

When consent has not been expressed, opening and closing the settings modal shouldn't do anything.

Current Behavior

When consent has not been expressed, opening and closing also unchecks all categories.

Steps to reproduce

//

Proposed fix or additional info.

This is caused by the internal discardUnsavedToggles() function introduced in v2.9.0

Version

v2.9.0

On which browser do you see the issue?

Chrome
@orestbida orestbida added the bug Something isn't working label May 12, 2023
@orestbida orestbida added this to the v2.9.1 milestone May 12, 2023
@github-actions github-actions bot added the triage yet to be reviewed label May 12, 2023
@orestbida orestbida added bug:confirmed and removed triage yet to be reviewed labels May 12, 2023
orestbida added a commit that referenced this issue May 13, 2023
@orestbida
Fix #516: properly discard unsaved toggles when modal is closed
952b5f5
@orestbida orestbida linked a pull request May 13, 2023 that will close this issue
v2.9.1 #517
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug:confirmed bug Something isn't working
Projects
None yet
Milestone
v2.9.1
Development

Successfully merging a pull request may close this issue.

v2.9.1 orestbida/cookieconsent
1 participant
@orestbida