Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: The preference modal bar layout is broken if button order is flipped #539

Closed
MoritzLost opened this issue Jun 22, 2023 · 5 comments
Closed
Labels
bug:confirmed bug Something isn't working
Milestone

Comments

@MoritzLost
Copy link
Contributor

MoritzLost commented Jun 22, 2023

Expected Behavior

With the preferences modal set to layout: bar and flipButtons: true, the button layout is broken:

Screen Shot 2023-06-22 at 12 34 43

The necessary button has additional margin to the top and right, but this only works in the default button order.

Current Behavior

Buttons lack spacing and are not of equal width.

Steps to reproduce

Use layout: bar and flipButtons: true under guiOptions.preferencesModal.

Proposed fix or additional info.

This could be fixed by using gap instead of margin to add some spacing between the buttons. This works regardless of flex-direction or grid-column settings.

Version

3.0.0-rc.15

On which browser do you see the issue?

Firefox

@MoritzLost MoritzLost added the bug Something isn't working label Jun 22, 2023
@github-actions github-actions bot added the triage yet to be reviewed label Jun 22, 2023
@orestbida orestbida added bug:confirmed and removed triage yet to be reviewed labels Jun 22, 2023
@orestbida orestbida added this to the v3.0.0-rc.16 milestone Jun 22, 2023
@orestbida
Copy link
Owner

Can confirm this is a bug!

Unfortunately the gap property is not supported in Safari < 14.1 when the flexbox layout is used: 8c01126.

@MoritzLost
Copy link
Contributor Author

MoritzLost commented Jun 23, 2023

Unfortunately the gap property is not supported in Safari < 14.1 when the flexbox layout is used: 8c01126.

Ah, right – we dropped iOS < 15 a while ago, so we've been able to use gap in flex layouts.
Is there an official list of supported browsers? All I found is the note in the comparison between v2 and v3:

Supports modern browsers only

@orestbida
Copy link
Owner

Unfortunately a consent management tool needs to have a reasonably wide browser support, so we're stuck with margin.

I don't know about specific browser ranges, probably all the browsers that support flexbox/grid and es6+. The oldest supported Safari version is 11.3.

@MoritzLost
Copy link
Contributor Author

@orestbida Got it, thanks! Might be a good idea to explicitly define browser support using browserslist.

@squareclouds
Copy link

@orestbida Got it, thanks! Might be a good idea to explicitly define browser support using browserslist.

yes!!! saying that v3 "Supports modern browsers only" is not helpful at all. a list with actual values would be good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug:confirmed bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants