Add language autodetection strategy based on <html lang>
#115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@orestbida Thanks, any idea when you plan to get this tagged and released? |
|
Ideally I'd like to work on all the remaining issues inside the v2.7 milestone except #85, since it's a big feature and I don't have a lot of time to work on it. I'd release v2.7 by the end of the week (optimistic) but - if you need it sooner - I could also skip the remaining issues and release instead something like a "v2.7-rc1". |
|
If you'd have a chance to release ty already merged features it sooner, it would be great. The rc version sounds nice 👍 Thanks for your work, really appreciate it! |
|
Just a quick note: if you use npm, you can also install dependencies directly from a git repository and reference a specific commit.
https://stackoverflow.com/questions/14187956/npm-install-from-git-in-a-specific-version/18049685
… Am 23.11.2021 um 17:18 schrieb Ondřej Machulda ***@***.***>:
If you'd have a chance to release ty already merged features it sooner, it would be great. The rc version sounds nice 👍
Thanks for your work, really appreciate it!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
@OndraM It's up! |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #114 .
First, internal value of
_config.auto_languageis now normalized to be either:browser(will use_getBrowserLang()) - alsotrueis classified asbrowser, to keep backward compatibilitydocument(will usedocument.documentElement.lang)null(disable auto detection), which is default in all other cases (includingfalsefor backward compatibility). I choosenullover false to be more type strict - now the value of auto_language is basically nullable string.After this, the
current_langis determined. I also refactored this to be in a separate method.