Clean up extraneous attributes to pass HTML validation. #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch removes unnecessary role="row" attributes from table rows and the tabindex="-1" attribute from focus spans allowing the results to pass local HTML validation.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
✅ Deploy Preview for cookieconsentv3-playground canceled.
|
orestbida
reviewed
Jun 10, 2023
orestbida
approved these changes
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch removes unnecessary role="row" attributes from table rows and the tabindex="-1" attribute from focus spans allowing the results to pass local HTML validation (run e.g. with Web Developer extension for Firefox or Chrome).
Removing the
role="row"attribute fixes the following error:The “role” attribute must not be used on a “tr” element which has a “table” ancestor with no “role” attribute, or with a “role” attribute whose value is “table”, “grid”, or “treegrid”.Removing the tabindex should not affect functionality since it defaults to -1, but it avoids putting that in the resulting HTML which would cause the following error:
An element with the attribute “tabindex” must not appear as a descendant of the “button” element.If there's something I'm overlooking, please let me know and I'll try to fix it. :)