Allow the _to_json of AgentID to be used to generate the JSON for AgentIDs #318
+0
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any idea why we had a special case handling for |
|
I traced where it came from. I think the logic in the Message constructor predates the |
…e stringified values
notthetup
force-pushed
the
fjagepy-agentid
branch
from
3ac014a
to
b5a3651
Compare
mchitre
approved these changes
Jul 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
Messageconstructors of fjage.py we were forcing all theAgentIDtypes to be converted tov.namebefore setting their values on the message objects. This looses information about if aAgentIDis aTopicetc.So instead, we let the
_to_jsonmethod ofAgentIDdo the proper stringification when the Message is converted to JSON.