Feat/s3 public access block

[OlafConijn]

what do you think about:

• ./src/common.ts?
• behavior on delete. regardless of what what was configured before it will be set to all false.... does that make sense?

[eduardomourar]

If you run the contract test from CFN CLI, the delete will fail if you can still retrieve the resource afterwards: https://docs.aws.amazon.com/cloudformation-cli/latest/userguide/resource-type-test-contract.html

[eduardomourar]

with the changes suggested, I am happy with the contract test results:

handler_create.py::contract_create_delete PASSED                                                                                                         [  7%]
handler_create.py::contract_invalid_create FAILED                                                                                                        [ 15%]
handler_create.py::contract_create_duplicate SKIPPED                                                                                                     [ 23%]
handler_create.py::contract_create_read_success PASSED                                                                                                   [ 30%]
handler_delete.py::contract_delete_read PASSED                                                                                                           [ 38%]
handler_delete.py::contract_delete_update FAILED                                                                                                         [ 46%]
handler_delete.py::contract_delete_delete FAILED                                                                                                         [ 53%]
handler_delete.py::contract_delete_create SKIPPED                                                                                                        [ 61%]
handler_misc.py::contract_check_asserts_work PASSED                                                                                                      [ 69%]
handler_read.py::contract_read_without_create PASSED                                                                                                     [ 76%]
handler_update.py::contract_update_read_success PASSED                                                                                                   [ 84%]
handler_update_invalid.py::contract_update_create_only_property SKIPPED                                                                                  [ 92%]
handler_update_invalid.py::contract_update_non_existent_resource FAILED                                                                                  [100%]
=================================================================== short test summary info ====================================================================
FAILED handler_create.py::contract_invalid_create - AssertionError: status should be FAILED
FAILED handler_delete.py::contract_delete_update - AssertionError: status should be FAILED
FAILED handler_delete.py::contract_delete_delete - AssertionError: status should be FAILED
FAILED handler_update_invalid.py::contract_update_non_existent_resource - AssertionError: status should be FAILED
========================================= 4 failed, 6 passed, 3 skipped, 3 deselected, 9 warnings in 79.60s (0:01:19) ==========================================

[eduardomourar]

i have tested multiple scenarios (with and without pre-existing resource) using the resource itself based on the example and everything is working as expected:

1. create
2. update (single or multiple properties)
3. delete

we are able to start managing the resource even if they are already there (just like we discussed)