Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Edit on Github" and "Translate to..." buttons #78

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

biodranik
Copy link
Member

Check the bottom of each page, there should be two buttons to easily edit the page or translate it to a new language.

@biodranik biodranik requested review from vng and rtsisyk December 12, 2022 00:24
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Dec 12, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4c4c716
Status: ✅  Deploy successful!
Preview URL: https://19937870.organicmaps.pages.dev
Branch Preview URL: https://edit-translations-on-github.organicmaps.pages.dev

View logs

@biodranik biodranik force-pushed the edit-translations-on-github branch from 8512c0f to 2608e2a Compare December 12, 2022 00:43
@biodranik
Copy link
Member Author

@rtsisyk PTAL, let's see if we get more translators via Github.

@biodranik biodranik force-pushed the edit-translations-on-github branch from 2608e2a to d0fd95e Compare December 14, 2022 10:09
@biodranik
Copy link
Member Author

We can easily detect the browser's languages and make a list of translations that are NOT present yet on the website. And show the "Translate to..." box only if there are some new languages in the user's browser.

@biodranik biodranik force-pushed the edit-translations-on-github branch from d0fd95e to e7590fc Compare December 14, 2022 10:13
@rtsisyk
Copy link
Member

rtsisyk commented Dec 16, 2022

Can we wait for feedback in organicmaps/organicmaps#4076 before enforcing any alternative approches? Users will start editing markdowns that are generated (like Indonesian) and it will create total mess.

@biodranik
Copy link
Member Author

  1. It will be helpful to see what should be changed. After (if) users create PRs, their fixes can be (at the moment) applied to Weblate.
  2. It is possible to disable Edit on GH and leave only Translate To... logic.

@rtsisyk
Copy link
Member

rtsisyk commented Feb 11, 2023

Can we add a link to https://hosted.weblate.org/projects/organicmaps/website/ instead?

@biodranik
Copy link
Member Author

@rtsisyk there is no need to show the same link to weblate on each page. It can be placed somewhere in the bottom menu instead, for example.

This PR opens the page that is currently viewed.

Signed-off-by: Alexander Borsuk <me@alex.bio>
Signed-off-by: Alexander Borsuk <me@alex.bio>
@biodranik biodranik force-pushed the edit-translations-on-github branch from e7590fc to 4c4c716 Compare February 11, 2023 23:18
@biodranik
Copy link
Member Author

@rtsisyk rebased, PTAL

@biodranik
Copy link
Member Author

@rtsisyk а нельзя обновлять po файлы из исправленных markdown? Получается, дорога в weblate - в один конец. И если надо что-то быстро поправить, то сейчас это придётся делать долго, через weblate.

@rtsisyk
Copy link
Member

rtsisyk commented Feb 21, 2023

@rtsisyk а нельзя обновлять po файлы из исправленных markdown? Получается, дорога в weblate - в один конец. И если надо что-то быстро поправить, то сейчас это придётся делать долго, через weblate.

Искусственный интеллект для обратного запихивания денормализированного текста в нормализированное представление пока еще не изобрели.

@biodranik
Copy link
Member Author

biodranik commented Feb 21, 2023

Искусственный интеллект для обратного запихивания денормализированного текста в нормализированное представление пока еще не изобрели.

@rtsisyk Ты же можешь поправить скрипт, чтобы po файлы обновлялись из маркдаунов?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants