Dependency graph does not support pnpm v9

[vluoto]

Select Topic Area

Bug

Body

Pnpm changed its lockfile format (from lockfile version 6.0 to 9.0) in v9 (release notes). Dependency graph no longer detects dependencies from lockfiles after upgrading pnpm from v8 to v9.

Before

After

[github-actions[bot]]

💬 Your Product Feedback Has Been Submitted 🎉

Thank you for taking the time to share your insights with us! Your feedback is invaluable as we build a better GitHub experience for all our users.

Here's what you can expect moving forward ⏩

• Your input will be carefully reviewed and cataloged by members of our product teams. 
  • Due to the high volume of submissions, we may not always be able to provide individual responses.
  • Rest assured, your feedback will help chart our course for product improvements.
• Other users may engage with your post, sharing their own perspectives or experiences. 
• GitHub staff may reach out for further clarification or insight. 
  • We may 'Answer' your discussion if there is a current solution, workaround, or roadmap/changelog post related to the feedback.

Where to look to see what's shipping 👀

• Read the Changelog for real-time updates on the latest GitHub features, enhancements, and calls for feedback.
• Explore our Product Roadmap, which details upcoming major releases and initiatives.

What you can do in the meantime 💻

• Upvote and comment on other user feedback Discussions that resonate with you.
• Add more information at any point! Useful details include: use cases, relevant labels, desired outcomes, and any accompanying screenshots.

As a member of the GitHub community, your participation is essential. While we can't promise that every suggestion will be implemented, we want to emphasize that your feedback is instrumental in guiding our decisions and priorities.

Thank you once again for your contribution to making GitHub even better! We're grateful for your ongoing support and collaboration in shaping the future of our platform. ⭐

[vluoto]

Here's two public repositories showcasing the issue:

• https://github.com/vluoto/dependency-graph-pnpm-v8 (success)
• https://github.com/vluoto/dependency-graph-pnpm-v9 (failure)

Notice how in v8 (with lockfile v6), the dependency graph includes a large number of transitive dependencies from the lockfile, whereas in v9 (with lockfile v9), it does not.

Screens for completeness sake:

[heartbreath180]

ملتا مسخره کردن پشتیبانی گوزززز

[rabbitbrother91031]

Hi, @vluoto

Please try to verify if the tool or service you are using for the dependency graph has updated its support for pnpm v9. Sometimes, tools may take time to catch up with major version changes.

[vluoto]

If you're referring to something like https://github.com/microsoft/sbom-tool, we're not currently using it. Instead, we're relying on GitHub's official support for pnpm in Dependency Graph. However, we may need to revert to using sbom-tool while we wait for GitHub to add support for pnpm v9, which was released about four months ago in April.

See the below comment for GitHub Enterprise Support's reply on the matter.

[vluoto]

Got this reply from GitHub Enterprise Support:

Thank you for contacting GitHub Enterprise Support!

We're always working to improve GitHub and we consider every suggestion we receive. I relayed this to the Dependency graph engineers and they confirmed that they are planning to offer support for pnpm v9 some time later this year.

While we don't currently have that functionality implemented, I've gone ahead and added your organization's voice to the internal Issue tracking the feature request . At this time we can't say when or if it will be released but we'd recommend that you keep an eye on the GitHub changelog where updates are announced.

[jeasmith]

It looks as though support for v9 lockfile is starting to be rolled out. We've seen both transitive dependencies and dependabot security alerts return in our repo. There's no indication as to what has changed, but we are awaiting a response from enterprise support to hopefully provide some detail.

[jeasmith]

@vluoto I've had a response form enterprise support regarding the visibility of the change.

This is not currently available in our public changelog. The change was classified as a rudimentary support to accompany support for previous versions. So this is a workaround pending when more granular change can be done.

[vluoto]

Thanks @jeasmith. That explains things.

[bvincent]

Hello,

Do you know on which GitHub Enterprise Server version the fix is available ?

Regards,