Refreshed Pull Request Commits Page Feedback

[willsmythe]

The pull request commits page has been refreshed to improve performance, improve consistency with other pages, and to make the experience more accessible!

To minimize disruptions, the capabilities of the classic commits page have been maintained, with a few exceptions: you can now use arrow keys to navigate the list of commits (instead of j and k) and focus indicators have been improved for better visual distinction.

Note: The roll-out of this refreshed page will begin on September 4, 2024.

Opt out

To switch back to the classic commits page, disable the "New Pull Request Commits Experience" feature preview (learn more).

Feedback

Have a question? Have feedback? Tell us below!

[JonathanRefera]

Worked well and fast. No bugs found. Good.

[ilyagr]

Indeed, works great for me too so far. Haven't noticed a difference (except for the "beta" badge) without closely looking.

[Huucanh990]

Cảm thấy hoạt động khá OK

[tudel31]

yeah

[Rebellmw]

Top

[nathanielop]

On pull requests with several commits- scrolling up too fast causes the header to jump before/after the sticky one is unrendered

[willsmythe]

Thanks for the feedback. Which browser are you seeing this on? And if you're able to capture a video of the problem, can you post it here? If not, no worries, we'll investigate regardless.

[maciejs-bp]

The difference in UX is quite big - at least on Chrome/Linux arrow keys scroll the page by default. Even after focusing the commit list with Tab I can only navigate a single commit group and nothing happens after selecting a commit with Return. On the old one I could navigate immediately with j/k (which feels natural to Vim users) and pressing Return opened the commit.

[willsmythe]

Thanks for the feedback.

• We plan on fixing the issue where you can't navigate the full list of commits with the down/up arrow keys
• We also plan on fixing the issue with Return/Enter not navigating to that commit
• We intentionally removed j and k support for accessibility reasons, but we're exploring ways to support them (but not impact accessibility). Stay tuned!

[LasseRafn]

• PR Author now has underline under the name, which is inconsistent with other PR UIs
  

• Diff no longer has decimal separators
  

• Scrolling fast, as reported by others, causes the page to jump up and down

[inkblotty]

@LasseRafn - Thank you for the report 🙏 On the first issue, do you have the Link Underline setting turned off? Just for additional context here.

[baptiste-n42]

I noticed that the deletion icons (red cubes) are striped on the commit page but not on the rest of the tabs. Maybe it's normal.

[nwnk]

[Araxeus]

This is unrelated to the refresh, it was like that before

[jesseduffield]

This may not be the right place to ask, but I'd like to have the option to view a page which shows file changes commit-by-commit, so it starts at the first commit with its description and file changes, and then you scroll down and eventually you reach the second commit with its file changes, etc. Currently I have to choose between:

1. Just looking at the final diff
2. Opening a new browser tab for each commit and then going through each tab

[Araxeus]

Not a big fan of the new buttons, its not very clear at a glance that those are buttons unlike the old design

[Billonwill]

Definitely its irritative design

[jez]

There's a counterintuitive result in interface design where the ease with which a button can be clicked is proportional to the size of the button in the UI, not just the size of the click target.

In the new design, since there is no background around the button by default, it gives the impression to users that they must be precise in clicking only the text, so they'll slow down their mouse cursor as they get closer to the commit text.

If the commit button were to be larger, like it was in the old design, users will understand the click target to be larger and know that they don't have to be so precise in clicking the button, making it easier to click.

Posting because I've noticed myself doing this every time I go to click the new commit buttons, even though in my head I know that the clickable area is the same size as it always was. Would love if we could get a better visual indicator that these are buttons, not just links.

[Sebastian-Brud-Tectonic]

Broken branch names. It keeps saying release%2FXYZ is not a proper branch name. Broken feature

[aelnosu]

Hi, The verify tag is not being shown consistently. If the commit is signed with S/MIME the verified tag is different between the PR page and that individual patch page.

[aelnosu]

Personally, I would prefer the verified tag on the individual patch page, but I hope there is more space between the profile picture and the title.

[okarny]

I wish there was a view in which you could see when you submitted a review in the series of commits. So I know after I requested for changes then the Engineer makes commits following that I can look at those more closely.

[ShineZaw123]

good

[aaronmarkey]

Could we have some way to see the actual date and time commits were made? "Last week" is extraordinarily unhelpful.

[willsmythe]

Across GitHub (and on this page), you should be able to hover your mouse over "last week" or "3 days ago" or whatever and see the exact date and time in a tooltip, for example:

[hsuabina]

I think I found a bug. I have a PR opened, where I'm not seeing the last commit and I can't merge:

The PR view (note it ends in #35c6848e):

If I browse the branch commits, the last one is there (#219f454):

If I try to merge the PR I get this error:

In git (not github) the branch looks OK in the remote.

[hsuabina]

I checked today again and the last commit was finally showing in the PR commit list, and the PR could be merged.

Not sure if this was fixed or if it was a temporary glitch 🤷🏼

[inkblotty]

Thanks for the report either was @hsuabina - Please let us know if it resurfaces.

[hsuabina]

So far so good!

[joedownard]

Changing the base branch of a PR sometimes doesn't work on the new flow whereas it does work on the old flow.
I get the error "Proposed base branch '...my branch...' was not found"

[mbutsko]

I need a condensed version.

[dskecse]

Most of the time, I feel like I need to copy short commit hashes, not full ones, but there's no way to do this on a new PR commits page:


Please add an easy and fast way to copy a short commit hash, right now it's a link that makes it really hard to copy the text and I always end up clicking the link to do so, which adds 2-3 extra clicks

[dskecse]

@adlai I suggest you learn yourself some manners first

[clarkdave]

I find the tooltip for the "Show description" button a bit too aggressive.

Specifically, it does not go away even after you've clicked the button, which means the tooltip actually covers up the corner of the content you wanted to see. It also doesn't go away even after moving the mouse (which I guess is a bug)

github-tooltip.mov

This is in Firefox 130.0 on MacOS 14.3

[smali-kazmi]

on Safari if you scroll down PR sticky header apply but with some jerk and there is a spot when it jerk a lot

Screen.Recording.2024-09-16.at.10.32.17.PM.mov

[inkblotty]

Thank you for the report. We are tracking a fix internally 👍

[devan-shanker]

%2F appearing on PRs with / in title, resulting in branch not found error sometimes

[Laurens256]

Small inconsistency that was mentioned here before but I'll add some extra info. With the accessibility setting "show link underlines" enabled, the PR author's username gets an underline in the "commits" tab but not in the other tabs

With the accessibility setting disabled none of them have underlines