-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debugger implementation #13433
base: main
Are you sure you want to change the base?
Debugger implementation #13433
Commits on Jul 31, 2024
-
Fix use correct request to stop thread (#11)
* Fix clippy * Remove increment request sequence (wrong while merging) * Send correct request to stop thread based on capabilities
Configuration menu - View commit details
-
Copy full SHA for aa257ec - Browse repository at this point
Copy the full SHA aa257ecView commit details -
Act on capabilities when sending requests (#12)
* Fix used wrong request args in set breakpoints request Some debug adapters depend on getting the exact data that you passed in `launch` or `attach` request. * Send correct request for stopping debug adapter I changed the name to be more in line with the request name. We now also send the correct request values on the `support_terminate_debuggee` and `support_terminate_debuggee` capabilities. * Send disconnect request for terminate threads if it does not support it * Only send configuration done request if its supported * Add disconnect icon * Only send step over request params when adapter supports it * Only send resume(continue) request params if adapter supports it * Step in only send request args if adapter supports it * Step out only send request args if adapter supports it * Step back only send request args if adapter supports it * Log error using `detach_and_log_err` instead of manually
Configuration menu - View commit details
-
Copy full SHA for 1c98c1c - Browse repository at this point
Copy the full SHA 1c98c1cView commit details -
Configuration menu - View commit details
-
Copy full SHA for fc4d46e - Browse repository at this point
Copy the full SHA fc4d46eView commit details -
Configuration menu - View commit details
-
Copy full SHA for c99865b - Browse repository at this point
Copy the full SHA c99865bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7ff1a08 - Browse repository at this point
Copy the full SHA 7ff1a08View commit details -
Configuration menu - View commit details
-
Copy full SHA for a0123e8 - Browse repository at this point
Copy the full SHA a0123e8View commit details -
Configuration menu - View commit details
-
Copy full SHA for a82d759 - Browse repository at this point
Copy the full SHA a82d759View commit details
Commits on Aug 1, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e974dde - Browse repository at this point
Copy the full SHA e974ddeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 42aefb4 - Browse repository at this point
Copy the full SHA 42aefb4View commit details -
Configuration menu - View commit details
-
Copy full SHA for ca84463 - Browse repository at this point
Copy the full SHA ca84463View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9dfd2f5 - Browse repository at this point
Copy the full SHA 9dfd2f5View commit details -
Change breakpoint DS back so it uses buffer_id as a key
I also made a new DS specifically for breakpoints that aren't part of any open buffers. It should be easier to serialize and deserialize breakpoints now.
Configuration menu - View commit details
-
Copy full SHA for 8b63c1a - Browse repository at this point
Copy the full SHA 8b63c1aView commit details
Commits on Aug 3, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d4904f9 - Browse repository at this point
Copy the full SHA d4904f9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0247fd6 - Browse repository at this point
Copy the full SHA 0247fd6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 68158d3 - Browse repository at this point
Copy the full SHA 68158d3View commit details
Commits on Aug 4, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e24e5f7 - Browse repository at this point
Copy the full SHA e24e5f7View commit details -
Configuration menu - View commit details
-
Copy full SHA for b1d830c - Browse repository at this point
Copy the full SHA b1d830cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5f4affd - Browse repository at this point
Copy the full SHA 5f4affdView commit details -
Configuration menu - View commit details
-
Copy full SHA for f3cb4a4 - Browse repository at this point
Copy the full SHA f3cb4a4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4181c39 - Browse repository at this point
Copy the full SHA 4181c39View commit details -
Configuration menu - View commit details
-
Copy full SHA for ef63ccf - Browse repository at this point
Copy the full SHA ef63ccfView commit details
Commits on Aug 5, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 96bdeca - Browse repository at this point
Copy the full SHA 96bdecaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 49dd57d - Browse repository at this point
Copy the full SHA 49dd57dView commit details -
Configuration menu - View commit details
-
Copy full SHA for f4af5af - Browse repository at this point
Copy the full SHA f4af5afView commit details -
Configuration menu - View commit details
-
Copy full SHA for a4cc28f - Browse repository at this point
Copy the full SHA a4cc28fView commit details
Commits on Aug 6, 2024
-
Handle case where Code action indicator interlaps with breakpoint
Code action's that overlap with breakpoints will now show as red. Still need to add a code action to toggle a breakpoint & handle overlaps with code runners
Configuration menu - View commit details
-
Copy full SHA for c92ecc6 - Browse repository at this point
Copy the full SHA c92ecc6View commit details
Commits on Aug 7, 2024
-
Show a breakpoint on line with code action while code action symbol i…
…s loading I also handle overlaps with code test buttons as well
Configuration menu - View commit details
-
Copy full SHA for 1ad8ed7 - Browse repository at this point
Copy the full SHA 1ad8ed7View commit details -
Get project::has_active_debuggers to return true if a debugger is run…
…ning instead of starting We shouldn't consider a debugger active until it's running because it may fail during it's starting phase. Also, this check is used determine if we should update a file's breakpoints when one is toggled.
Configuration menu - View commit details
-
Copy full SHA for 111a0dc - Browse repository at this point
Copy the full SHA 111a0dcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5a08fc2 - Browse repository at this point
Copy the full SHA 5a08fc2View commit details -
Get breakpoints to display in the correct positions within multi buffers
Remco Smits <djsmits12@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 7d243ac - Browse repository at this point
Copy the full SHA 7d243acView commit details -
Configuration menu - View commit details
-
Copy full SHA for a4db59c - Browse repository at this point
Copy the full SHA a4db59cView commit details -
Configuration menu - View commit details
-
Copy full SHA for cb52082 - Browse repository at this point
Copy the full SHA cb52082View commit details -
Fix bug that caused a breakpoints to only remain persistent in one op…
…en file when booting zed up
Configuration menu - View commit details
-
Copy full SHA for d3fe698 - Browse repository at this point
Copy the full SHA d3fe698View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0f1738c - Browse repository at this point
Copy the full SHA 0f1738cView commit details
Commits on Aug 8, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 30b59a6 - Browse repository at this point
Copy the full SHA 30b59a6View commit details -
Configuration menu - View commit details
-
Copy full SHA for fe58a70 - Browse repository at this point
Copy the full SHA fe58a70View commit details
Commits on Aug 12, 2024
-
Show variables recursively (#16)
* WIP Show variables in toggable list items * Use more unique element id so we can group variables by name and reference * Fix correct pass in listItem toggle value * Fix we did not set the current stack frame id * WIP start fetching variables recursively * Remove duplicated code for current stack frame id * Fetch all variables for each stack frame parallel * Fetch all variable on the same level parallel * Rename vars so its more clear * Refactor how we store thread data We now store the information in a better way so we could filter on it easier and faster. * Remove unused code * Use stack frame id as top level key instead of struct itself * Add has_children to scope thread entry * Fix allow switching current stack frame Also fixed building list entries twice right after each other * Show message when scope does not have variables * Remove scope if it does not have variables * Add allow collapsing scopes * Add allow collapsing variables * Add docs to determine collapsed variables * Allow collapsing variables and always show first scope variables * Correctly fix collapse variables * Fix clippy
Configuration menu - View commit details
-
Copy full SHA for 5678469 - Browse repository at this point
Copy the full SHA 5678469View commit details
Commits on Aug 14, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 26e9843 - Browse repository at this point
Copy the full SHA 26e9843View commit details -
Configuration menu - View commit details
-
Copy full SHA for b561c68 - Browse repository at this point
Copy the full SHA b561c68View commit details -
Fix wrong value for always showing disclosure icon
Oopss, after testing i did commit the wrong value.
Configuration menu - View commit details
-
Copy full SHA for 9ea23b0 - Browse repository at this point
Copy the full SHA 9ea23b0View commit details -
Remove debugger client when its terminated (#18)
* Only terminate thread if it did not already end * Remove debug client when its terminated
Configuration menu - View commit details
-
Copy full SHA for 9643e71 - Browse repository at this point
Copy the full SHA 9643e71View commit details -
Configuration menu - View commit details
-
Copy full SHA for bb40689 - Browse repository at this point
Copy the full SHA bb40689View commit details
Commits on Aug 15, 2024
-
Co-authored-by: Remco Smits <djsmits12@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 3a3f499 - Browse repository at this point
Copy the full SHA 3a3f499View commit details -
Set up ground work for debugger settings & save breakpoints setting
Co-authored-by: Remco Smits <djsmits12@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for e9f0e93 - Browse repository at this point
Copy the full SHA e9f0e93View commit details -
Configuration menu - View commit details
-
Copy full SHA for da1fdd2 - Browse repository at this point
Copy the full SHA da1fdd2View commit details
Commits on Aug 18, 2024
-
* Lazy fetch * Remove unused code * Clean up fetch nested variable * Include scope id for variable id to be more unique * Clean up not needed get_mut function calls
Configuration menu - View commit details
-
Copy full SHA for 11b2bc1 - Browse repository at this point
Copy the full SHA 11b2bc1View commit details
Commits on Aug 21, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 1ac97d2 - Browse repository at this point
Copy the full SHA 1ac97d2View commit details -
Configuration menu - View commit details
-
Copy full SHA for db8b8be - Browse repository at this point
Copy the full SHA db8b8beView commit details -
Add todo to fix bug & bug information
Co-authored-by: Remco Smits <djsmits12@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for fb169af - Browse repository at this point
Copy the full SHA fb169afView commit details -
Merge debugger into breakpoints
Co-authored-by: Remco Smits <djsmits12@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 5c45e45 - Browse repository at this point
Copy the full SHA 5c45e45View commit details -
Merge pull request #13 from Anthony-Eid/breakpoints
Make breakpoints persistent across Zed sessions
Configuration menu - View commit details
-
Copy full SHA for 2843a36 - Browse repository at this point
Copy the full SHA 2843a36View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7885da1 - Browse repository at this point
Copy the full SHA 7885da1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3c98e89 - Browse repository at this point
Copy the full SHA 3c98e89View commit details -
Configuration menu - View commit details
-
Copy full SHA for 651c31c - Browse repository at this point
Copy the full SHA 651c31cView commit details -
Configuration menu - View commit details
-
Copy full SHA for bbb449c - Browse repository at this point
Copy the full SHA bbb449cView commit details
Commits on Aug 22, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 149116e - Browse repository at this point
Copy the full SHA 149116eView commit details
Commits on Aug 23, 2024
-
Add debug icon to toggle debug panel (#23)
* Add debug icon to toggle debug panel * Add setting to wether to show the debug button * Fix clippy
Configuration menu - View commit details
-
Copy full SHA for f3e7129 - Browse repository at this point
Copy the full SHA f3e7129View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9bcd03b - Browse repository at this point
Copy the full SHA 9bcd03bView commit details
Commits on Aug 24, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 618d81a - Browse repository at this point
Copy the full SHA 618d81aView commit details
Commits on Aug 25, 2024
-
Improve clear highlights performance (#25)
* Only clear highlights op open tabs This much better so we don't have to open each path of each stack frame in each thread. * Don't open the same file twice for clearing thread highlights
Configuration menu - View commit details
-
Copy full SHA for 5a301fc - Browse repository at this point
Copy the full SHA 5a301fcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 31b27e1 - Browse repository at this point
Copy the full SHA 31b27e1View commit details -
Remove duplicated content code for debugger settings (#27)
Refactored this because its being refactored inside: zed-industries#16744
Configuration menu - View commit details
-
Copy full SHA for 199b665 - Browse repository at this point
Copy the full SHA 199b665View commit details -
Configuration menu - View commit details
-
Copy full SHA for 045f927 - Browse repository at this point
Copy the full SHA 045f927View commit details
Commits on Aug 26, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 2b504b3 - Browse repository at this point
Copy the full SHA 2b504b3View commit details -
* Create debugger console * Get console to output console messages during output events * Use match expression in handle_output_event * Move debug console code to it's own file console
Configuration menu - View commit details
-
Copy full SHA for 008b6b5 - Browse repository at this point
Copy the full SHA 008b6b5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 921d0c5 - Browse repository at this point
Copy the full SHA 921d0c5View commit details
Commits on Aug 27, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 3ac4d1e - Browse repository at this point
Copy the full SHA 3ac4d1eView commit details
Commits on Aug 28, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 243bd4b - Browse repository at this point
Copy the full SHA 243bd4bView commit details -
Configuration menu - View commit details
-
Copy full SHA for fc4078f - Browse repository at this point
Copy the full SHA fc4078fView commit details
Commits on Aug 31, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 4cf735b - Browse repository at this point
Copy the full SHA 4cf735bView commit details
Commits on Sep 1, 2024
-
Make stepping granularity configurable (#33)
This commit also changes the default granularity to line, before this was statement but most editors have line as the default.
Configuration menu - View commit details
-
Copy full SHA for 83cc452 - Browse repository at this point
Copy the full SHA 83cc452View commit details
Commits on Sep 3, 2024
-
Show warning when session exited without hitting any breakpoint (#31)
* Show warning when session did not stop but exited * Fix code was not formatted any more * Fix clippy
Configuration menu - View commit details
-
Copy full SHA for 7b7a475 - Browse repository at this point
Copy the full SHA 7b7a475View commit details
Commits on Sep 7, 2024
-
Allow setting variable value (#34)
* Wip render set variable value editor * Remove unused subscriptions * Set current variable value & select all when setting value * Send set variable request * Rename tread entry to VariableListEntry * WIP allow setting variables for nested structures * Refactor & rename vars on thread state to be only the ids * Fix we did not correct notify the right context when updating variable list * Clean open entries when debugger stops * Use SetExpression if adapter supports it when setting value * Refetch scope variables after setting value This commit also reworks how we store scopes & variables * Remove debug code * Make Clippy happy * Rename variable * Change order for variable id * Allow cancelling set value using escape key
Configuration menu - View commit details
-
Copy full SHA for b009832 - Browse repository at this point
Copy the full SHA b009832View commit details -
Configuration menu - View commit details
-
Copy full SHA for ac2aa79 - Browse repository at this point
Copy the full SHA ac2aa79View commit details -
Configuration menu - View commit details
-
Copy full SHA for edf4e53 - Browse repository at this point
Copy the full SHA edf4e53View commit details
Commits on Sep 8, 2024
-
Move breakpoint & debug client code to dap_store (#36)
* Move breakpoint and client code to dap store This also changes how we sync breakpoints. Now we just update the dap store model instead of having a RWlock. The goal is to prepare for making inlay hints for debugging work. * Remove debug code * Remove unused method * Fix don't grow the amount tasks for sending all the breakpoints * Partially implement terminate clients when app quits * Sync open breakpoints to closed breakpoints when buffer is closed * Call terminate request also for not already started clients * Fix missing import * Remove not needed read_with call
Configuration menu - View commit details
-
Copy full SHA for b00d63b - Browse repository at this point
Copy the full SHA b00d63bView commit details -
Configuration menu - View commit details
-
Copy full SHA for b2927a0 - Browse repository at this point
Copy the full SHA b2927a0View commit details -
Configuration menu - View commit details
-
Copy full SHA for dc5d0f4 - Browse repository at this point
Copy the full SHA dc5d0f4View commit details -
Make Debug tasks easier for a user to config
* Start setting up new debug task format * Set up blueprint for converting from debug task to regular task * Create debug adapter trait * Get debug.json schema to json lsp to show users hints * Start debugger task refactor to enable easier debugger setup * Get python adapter to work within task.json co-authored-by: Piotr <piotr@zed.dev> * Start work on getting Php Debug adapter working * Make debug adapter trait work with async functions Fix CICD spell check & clippy warnings Co-authored-by: Remco Smits <djsmits12@gmail.com> --------- Co-authored-by: Piotr <piotr@zed.dev> Co-authored-by: Remco Smits <djsmits12@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 1e99694 - Browse repository at this point
Copy the full SHA 1e99694View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0e6042e - Browse repository at this point
Copy the full SHA 0e6042eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 165e058 - Browse repository at this point
Copy the full SHA 165e058View commit details -
Configuration menu - View commit details
-
Copy full SHA for 09c195e - Browse repository at this point
Copy the full SHA 09c195eView commit details
Commits on Sep 10, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 5d07ab0 - Browse repository at this point
Copy the full SHA 5d07ab0View commit details
Commits on Sep 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 3683920 - Browse repository at this point
Copy the full SHA 3683920View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4990242 - Browse repository at this point
Copy the full SHA 4990242View commit details -
Change breakpoint position from multi_buffer::Anchor -> text::Anchor
This fixes a crash that happened when placing a breakpoint within a multi buffer where it's excerpt_id != 1. Co-authored-by: Remco Smits <djsmits12@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 5a0c7d2 - Browse repository at this point
Copy the full SHA 5a0c7d2View commit details -
Change open_breakpoint's BTree to use project_path as it's key
This is the first step of merging open/close breakpoints into one data structure. Co-authored-by: Remco Smits <djsmits12@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0f5e5ea - Browse repository at this point
Copy the full SHA 0f5e5eaView commit details -
Merge open/close breakpoints into one data structure
This is done by making breakpoint.position field optional and adding a cached_position field too. I also added dap_store to buffer_store and got buffer_store to initialize breakpoints when a new buffer is opened. Fixing a bug where some breakpoints wouldn't appear within multi buffers
Configuration menu - View commit details
-
Copy full SHA for e6049f9 - Browse repository at this point
Copy the full SHA e6049f9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3184ba1 - Browse repository at this point
Copy the full SHA 3184ba1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 18fb45f - Browse repository at this point
Copy the full SHA 18fb45fView commit details
Commits on Sep 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a4ce446 - Browse repository at this point
Copy the full SHA a4ce446View commit details -
Configuration menu - View commit details
-
Copy full SHA for ab6f334 - Browse repository at this point
Copy the full SHA ab6f334View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7a6f9d9 - Browse repository at this point
Copy the full SHA 7a6f9d9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3fac36b - Browse repository at this point
Copy the full SHA 3fac36bView commit details -
Get .zed/debug.json to resolve debug tasks properly
Co-authored-by: Piotr <piotr@zed.dev>
Configuration menu - View commit details
-
Copy full SHA for 8a835bc - Browse repository at this point
Copy the full SHA 8a835bcView commit details -
Configuration menu - View commit details
-
Copy full SHA for ed6da4a - Browse repository at this point
Copy the full SHA ed6da4aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 571d99c - Browse repository at this point
Copy the full SHA 571d99cView commit details
Commits on Sep 13, 2024
-
Correctly shutdown adapter (#37)
* Kill adapter and close channels * Always try to terminate the debug adapter * Remove TODO * Always allow allow the user to restart if capability allows it Co-Authored-By: Anthony Eid <56899983+Anthony-Eid@users.noreply.github.com> * Drop tasks Co-Authored-By: Anthony Eid <56899983+Anthony-Eid@users.noreply.github.com> * WIP fix hang * Remove debug code * clean up --------- Co-authored-by: Anthony Eid <56899983+Anthony-Eid@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 4405ae2 - Browse repository at this point
Copy the full SHA 4405ae2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9b82278 - Browse repository at this point
Copy the full SHA 9b82278View commit details -
Configuration menu - View commit details
-
Copy full SHA for 559173e - Browse repository at this point
Copy the full SHA 559173eView commit details -
Move Request, Response, Event types to dap-types repo
This also changes the concept of passing the receiver inside the request to make sure we handle all the requests in the right order. Now we have another peace of state that keeps track of the current requests, and when request comes in we move the receiver to the pending requests state and handle the request as we did before.
Configuration menu - View commit details
-
Copy full SHA for 3985963 - Browse repository at this point
Copy the full SHA 3985963View commit details
Commits on Sep 14, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 4694de8 - Browse repository at this point
Copy the full SHA 4694de8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 56943e2 - Browse repository at this point
Copy the full SHA 56943e2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 716a817 - Browse repository at this point
Copy the full SHA 716a817View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8cdb1fb - Browse repository at this point
Copy the full SHA 8cdb1fbView commit details
Commits on Sep 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 621d181 - Browse repository at this point
Copy the full SHA 621d181View commit details -
Configuration menu - View commit details
-
Copy full SHA for e7f7fb7 - Browse repository at this point
Copy the full SHA e7f7fb7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 142a6de - Browse repository at this point
Copy the full SHA 142a6deView commit details
Commits on Sep 17, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c1ab059 - Browse repository at this point
Copy the full SHA c1ab059View commit details -
Configuration menu - View commit details
-
Copy full SHA for c3a7787 - Browse repository at this point
Copy the full SHA c3a7787View commit details -
Configuration menu - View commit details
-
Copy full SHA for c883166 - Browse repository at this point
Copy the full SHA c883166View commit details
Commits on Sep 21, 2024
-
Refactor: Move types to the correct place and move specific request c…
…ode to the dapstore (#39) * Make dap store global * Partially move initialize & capability code to dap store * Reuse shutdown for shutdown clients * Rename merge_capabilities * Correctly fallback to current thread id for checking to skip event * Move mthod * Move terminate threads to dap store * Move disconnect and restart to dap store * Update dap-types to the correct version This includes the capabilities::merge method * Change dap store to WeakModel in debug panels * Make clippy happy * Move pause thread to dap store * WIP refactor out thread state and capbilities * Move update thread status to debug panel method * Remove double notify * Move continue thread to dap store * Change WeakModel dapStore to Model dapStore * Move step over to dap store * Move step in to dap store * Move step out to dap store * Remove step back we don't support this yet * Move threadState type to debugPanel * Change to background task * Fix panic when debugSession stopped * Remove capabilities when debug client stops * Add missing notify * Remove drain that causes panic * Remove Arc<DebugAdapterClient> from debug_panel_item instead use the id * Reset stack_frame_list to prevent crash * Refactor ThreadState to model to prevent recursion dependency in variable_list * WIP * WIP move set_variable_value and get_variables to dap store * Remove unused method * Fix correctly insert updated variables Before this changes you would see the variables * scopes. Because it did not insert the the variables per scope. * Correctly update current stack frame on variable list * Only allow building variable list entries for current stack frame * Make toggle variables & scopes work again * Fix clippy * Pass around id instead of entire client * Move set breakpoints to dap store * Show thread status again in tooltip text * Move stack frames and scope requests to dap store * Move terminate request to dap store * Remove gap that is not doing anything * Add retain back to remove also threads that belong to the client * Add debug kind back to tab content
Configuration menu - View commit details
-
Copy full SHA for 9612b60 - Browse repository at this point
Copy the full SHA 9612b60View commit details -
Configuration menu - View commit details
-
Copy full SHA for 278699f - Browse repository at this point
Copy the full SHA 278699fView commit details -
Configuration menu - View commit details
-
Copy full SHA for f1f1426 - Browse repository at this point
Copy the full SHA f1f1426View commit details -
Configuration menu - View commit details
-
Copy full SHA for c26a8f1 - Browse repository at this point
Copy the full SHA c26a8f1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4ddb65b - Browse repository at this point
Copy the full SHA 4ddb65bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8b96ac8 - Browse repository at this point
Copy the full SHA 8b96ac8View commit details
Commits on Sep 22, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 7dec58c - Browse repository at this point
Copy the full SHA 7dec58cView commit details -
Merge pull request #38 from Anthony-Eid/breakpoint-context-menu
Breakpoint Context Menu & Log Breakpoints
Configuration menu - View commit details
-
Copy full SHA for 231b5a9 - Browse repository at this point
Copy the full SHA 231b5a9View commit details -
Move all the debug panel actions to the workspace (#41)
This PR moves out all the actions from the **debug_panel_item** to the **workspace** which allows people to use these actions inside their key binds. I also had to remove the debug_panel dependency inside the debug_panel_item, because we hit a `"cannot update debug_panel while it is already being updated"` panic. So instead of updating the thread status inside the **debug_panel** we now do this inside the **debug_panel_item** to prevent this panic. I also move the actions to its own debugger namespace, so it's more clear what the actions are for. The new actions can now also be used for key binds: ``` debugger: start debugger: continue debugger: step into debugger: step over debugger: step out debugger: restart debugger: stop debugger: pause ``` /cc @Anthony-Eid We now can have key binds for debugger actions.
Configuration menu - View commit details
-
Copy full SHA for a3dff43 - Browse repository at this point
Copy the full SHA a3dff43View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9016a03 - Browse repository at this point
Copy the full SHA 9016a03View commit details
Commits on Sep 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ce77773 - Browse repository at this point
Copy the full SHA ce77773View commit details
Commits on Sep 24, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 9bc08f9 - Browse repository at this point
Copy the full SHA 9bc08f9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3b3ac85 - Browse repository at this point
Copy the full SHA 3b3ac85View commit details -
Configuration menu - View commit details
-
Copy full SHA for 29918d9 - Browse repository at this point
Copy the full SHA 29918d9View commit details
Commits on Sep 25, 2024
-
Show current debug line when you reopen a buffer (#42)
* Only include dap store if editor.mode is FULL * Move go to stack frame to debug_panel_item * Notify dap_store when updating active breakpoints location * Fix clippyyyy * Show active debug line when you reopen a buffer * Remove uncommented code This is not needed anymore, we already clear the highlights when thread exited * Make clippy happy * Fix todo for removing highlights on exited event
Configuration menu - View commit details
-
Copy full SHA for bfddc63 - Browse repository at this point
Copy the full SHA bfddc63View commit details -
Configuration menu - View commit details
-
Copy full SHA for 171ddfb - Browse repository at this point
Copy the full SHA 171ddfbView commit details
Commits on Sep 27, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 1914cef - Browse repository at this point
Copy the full SHA 1914cefView commit details
Commits on Oct 4, 2024
-
* Use buffer settings for font, size etc. * Trim end of message * By default send the output values to the output editor * WIP send evaluate request * Rename variable * Add result to console from evaluate response * Remove not needed arc * Remove store capabilities on variable_list * Specify the capacity for the task vec * Add placeholder * WIP add completion provider for existing variables * Add value to auto completion label * Make todo for debugger * Specify the capacity of the vec's * Make clippy happy * Remove not needed notifies and add missing one * WIP move scopes and variables to variable_list * Rename configuration done method * Add support for adapter completions and manual variable completions * Move type to variabel_list * Change update to read * Show debug panel when debug session stops Co-Authored-By: Anthony Eid <56899983+Anthony-Eid@users.noreply.github.com> Co-Authored-By: Mikayla Maki <mikayla.c.maki@gmail.com> * Also use scope reference to determine to which where the set value editor should display * Refetch existing variables after * Rebuild entries after refetching the variables --------- Co-authored-by: Anthony Eid <56899983+Anthony-Eid@users.noreply.github.com> Co-authored-by: Mikayla Maki <mikayla.c.maki@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 842bf02 - Browse repository at this point
Copy the full SHA 842bf02View commit details -
Merge branch 'main' into debugger
Co-authored-by: Anthony Eid <hello@anthonyeid.me>
Configuration menu - View commit details
-
Copy full SHA for 55c6570 - Browse repository at this point
Copy the full SHA 55c6570View commit details -
Fix current debug line highlight did not work
Co-authored-by: Anthony Eid <hello@anthonyeid.me>
Configuration menu - View commit details
-
Copy full SHA for 6b4ebac - Browse repository at this point
Copy the full SHA 6b4ebacView commit details -
Breakpoint prompt editor (#44)
* Create basic breakpoint prompt editor structure * Get breakpoint prompt to properly render * Fix bug where toggle breakpoint failed to work This bug occurs when a breakpoint anchor position is moved from the begining of a line. This causes dap_store.breakpoint hashmap to fail to properly get the correct element, thus toggling the wrong breakpoint. The fix to this bug is passing a breakpoint anchor to an editor's display map and to the render breakpoint function. Instead of creating a new anchor when clicking on a breakpoint icon, zed will use the breakpoint anchor passed to the display map. In the case of using toggle breakpoint action, zed will iterate through all breakpoints in that buffer to check if any are on the cursor's line number, then use anchor if found. Otherwise, zed creates a new anchor. * Fix bug where breakpoint icon overlaps with other icons This bug happened when an icon {code action | code runner} was rendered on the same line of a breakpoint where that breakpoint's anchor was not at the start of the line * Get breakpoint prompt to add log breakpoint's correctly * Clean up breakpoint prompt UI & allow editting of log messages --------- Co-authored-by: Remco Smits <djsmits12@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 93af1bf - Browse repository at this point
Copy the full SHA 93af1bfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3c301c3 - Browse repository at this point
Copy the full SHA 3c301c3View commit details -
Configuration menu - View commit details
-
Copy full SHA for f9b045b - Browse repository at this point
Copy the full SHA f9b045bView commit details
Commits on Oct 5, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c2ed56a - Browse repository at this point
Copy the full SHA c2ed56aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8c0a7b1 - Browse repository at this point
Copy the full SHA 8c0a7b1View commit details
Commits on Oct 6, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f76b7c9 - Browse repository at this point
Copy the full SHA f76b7c9View commit details
Commits on Oct 7, 2024
-
Move stack frame list to its own view (#47)
* WIP Move stack frame list to own module * Add missing notify * Remove some more duplicated state for the current stack frame * Clear highlights when stack frame has changed * Fix go to stack frame again
Configuration menu - View commit details
-
Copy full SHA for 3b545a7 - Browse repository at this point
Copy the full SHA 3b545a7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 984cb68 - Browse repository at this point
Copy the full SHA 984cb68View commit details -
Configuration menu - View commit details
-
Copy full SHA for ac0ba07 - Browse repository at this point
Copy the full SHA ac0ba07View commit details -
* Pass http client to dap store * Set up DapAdapterDelegate to use for DAP binary fetches * WIP to get debug adapters to use zed directory for installs * Get debugpy automatic download working * Change DapAdapter fetch_or_install to return a Result * Add node_runtime to dap delegate Co-authored-by: Remco Smits <djsmits12@gmail.com> * Create dap_adapter crate & move language dap adapter code to that crate This is the first phase of dap::client refactor to organize debug adapters with zed lsp adapters. Eventually dap::client will have a TransportParams pass to it instead of an adapter, and adapters will handle custom debug events. Co-authored-by: Remco Smits <djsmits12@gmail.com> * Move language specific dap adapter code to their own files * Move DebugAdapter member out of ClientDebugAdapter struct This change was done to make dap::client more in line with zed's lsp::client, it might be reverted depending on if this solution is cleaner or not. * Get php debug adapter to auto download when needed * Get adapter_path argument to work with auto download dap adapters --------- Co-authored-by: Remco Smits <djsmits12@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 187d909 - Browse repository at this point
Copy the full SHA 187d909View commit details
Commits on Oct 8, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 00b6fdc - Browse repository at this point
Copy the full SHA 00b6fdcView commit details -
Configuration menu - View commit details
-
Copy full SHA for eedd865 - Browse repository at this point
Copy the full SHA eedd865View commit details -
Remove new lines from variable list value
This fixes a display issue, for javascript expression values.
Configuration menu - View commit details
-
Copy full SHA for 08935b2 - Browse repository at this point
Copy the full SHA 08935b2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 91926cd - Browse repository at this point
Copy the full SHA 91926cdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5f1de1a - Browse repository at this point
Copy the full SHA 5f1de1aView commit details
Commits on Oct 9, 2024
-
Make start debugging request work again
This also fixes an issue that you could not add your own initialize_args for non custom adapters
Configuration menu - View commit details
-
Copy full SHA for 171c742 - Browse repository at this point
Copy the full SHA 171c742View commit details -
Configuration menu - View commit details
-
Copy full SHA for a728f9e - Browse repository at this point
Copy the full SHA a728f9eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8a4f677 - Browse repository at this point
Copy the full SHA 8a4f677View commit details -
Cleanup adapters code and add javascript adapter (#48)
* Clean up how adapters install and fetch their binary Before this was in one method, which was hard to read and doing to many things. * Add javascript debug adapter * Get node binary from node_runtime * Undo remove request args for lldb * Remove initialize value for now * Remove default values * Fix did not compile javascript * Fix php did not build
Configuration menu - View commit details
-
Copy full SHA for 7e2c138 - Browse repository at this point
Copy the full SHA 7e2c138View commit details
Commits on Oct 10, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 554a402 - Browse repository at this point
Copy the full SHA 554a402View commit details -
Add support for custom adapters
Also simplify the DebugAdapterBInary struct
Configuration menu - View commit details
-
Copy full SHA for 177ae28 - Browse repository at this point
Copy the full SHA 177ae28View commit details
Commits on Oct 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b1d24a0 - Browse repository at this point
Copy the full SHA b1d24a0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5bb7f24 - Browse repository at this point
Copy the full SHA 5bb7f24View commit details
Commits on Oct 13, 2024
-
Fix missing thread_state status update when client was terminated
Before this change the debug panel was still in the running state, which is/was wrong. So updating the status to Ended, will update the UI to an correct state.
Configuration menu - View commit details
-
Copy full SHA for 222cd4b - Browse repository at this point
Copy the full SHA 222cd4bView commit details
Commits on Oct 14, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b46b8aa - Browse repository at this point
Copy the full SHA b46b8aaView commit details -
* Remove not needed notify * Add loaded sources list * Remove not needed double nested div.child() * Remove not needed block * Fix todo for updating loaded source
Configuration menu - View commit details
-
Copy full SHA for 5758f66 - Browse repository at this point
Copy the full SHA 5758f66View commit details -
Configuration menu - View commit details
-
Copy full SHA for f5dc117 - Browse repository at this point
Copy the full SHA f5dc117View commit details -
Configuration menu - View commit details
-
Copy full SHA for c65ed1c - Browse repository at this point
Copy the full SHA c65ed1cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 13afc37 - Browse repository at this point
Copy the full SHA 13afc37View commit details
Commits on Oct 15, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 3a6f2ad - Browse repository at this point
Copy the full SHA 3a6f2adView commit details
Commits on Oct 17, 2024
-
* Make program optional in debug task format * Remove default config for skipFile JavaScript debugger * Add Debug case to TerminalKind * Don't allow serializing debug terminals * Add respond method so we can send response back for reverse requests * Implement run in terminal reverse request * Move client calls to dap store This commit also fixes an issue with not sending a response for the `StartDebugging` reverse request. * Make clippy happy
Configuration menu - View commit details
-
Copy full SHA for 1c1e34b - Browse repository at this point
Copy the full SHA 1c1e34bView commit details -
Configuration menu - View commit details
-
Copy full SHA for fdea7d9 - Browse repository at this point
Copy the full SHA fdea7d9View commit details -
Configuration menu - View commit details
-
Copy full SHA for afe228f - Browse repository at this point
Copy the full SHA afe228fView commit details
Commits on Oct 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 2e028a7 - Browse repository at this point
Copy the full SHA 2e028a7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6735cfa - Browse repository at this point
Copy the full SHA 6735cfaView commit details -
Move how we connect to an debug adpater to the transport layer (#52)
* Move how we connect to an debug adpater to the transport layer This PR cleans up how we connect to a debug adapter. Previously, this was done inside the debug adapter implementation. While reviewing the debugger RPC log view PR, I noticed that we could simplify the transport/client code, making it easier to attach handlers for logging RPC messages. * Remove not needed async block * Change hardcoded delay before connecting to tcp adapter to timeout approach Co-Authored-By: Anthony Eid <hello@anthonyeid.me> --------- Co-authored-by: Anthony Eid <hello@anthonyeid.me>
Configuration menu - View commit details
-
Copy full SHA for fc78c40 - Browse repository at this point
Copy the full SHA fc78c40View commit details -
Configuration menu - View commit details
-
Copy full SHA for 211fd50 - Browse repository at this point
Copy the full SHA 211fd50View commit details -
Configuration menu - View commit details
-
Copy full SHA for 30a4c84 - Browse repository at this point
Copy the full SHA 30a4c84View commit details
Commits on Oct 21, 2024
-
Implement logging for debug adapter clients (#45)
* Implement RPC logging for debug adapter clients * Implement server logs for debugger servers * This cleans up the way we pass through the input and output readers for logging. So not each debug adapters have to map the AdapterLogIO fields. I also removed some specific when has logs from the client, because the client is not responsible for that. Removed an not needed/duplicated dependency Fix formatting & clippy This cleans up the way we pass through the input and output readers for logging. So not each debug adapters have to map the AdapterLogIO fields. I also removed some specific when has logs from the client, because the client is not responsible for that. Removed an not needed/duplicated dependency Fix formatting & clippy * Implement `has_adapter_logs` for each transport impl * Make adapter stdout logging work * Add conditional render for adapter log back * Oops forgot to pipe the output * Always enable rpc messages Previously, RPC messages were only stored when explicitly enabled, which occurred after the client was already running. This approach prevented debugging of requests sent during the initial connection period. By always enabling RPC messages, we ensure that all requests, including those during the connection phase, are captured and available for debugging purposes. This could help use debug when someone has troble getting a debug starting. This improvement could be particularly helpful in debugging scenarios where users encounter issues during the initial connection or startup phase of their debugging sessions. --------- Co-authored-by: Remco Smits <djsmits12@gmail.com> Co-authored-by: Anthony Eid <hello@anthonyeid.me>
Configuration menu - View commit details
-
Copy full SHA for 43ea3b4 - Browse repository at this point
Copy the full SHA 43ea3b4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6f973bd - Browse repository at this point
Copy the full SHA 6f973bdView commit details -
Configuration menu - View commit details
-
Copy full SHA for b426ff6 - Browse repository at this point
Copy the full SHA b426ff6View commit details -
Configuration menu - View commit details
-
Copy full SHA for ffc0582 - Browse repository at this point
Copy the full SHA ffc0582View commit details
Commits on Oct 22, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 8baa280 - Browse repository at this point
Copy the full SHA 8baa280View commit details
Commits on Oct 23, 2024
-
Clean up DAP install code (#51)
* Clean up dap adapter install_binary functions * Get lldb-dap working when on macos * Add release tag to name of downloaded DAPs * Check if adapter is already installed before installing one
Configuration menu - View commit details
-
Copy full SHA for 61daad2 - Browse repository at this point
Copy the full SHA 61daad2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 932f4ed - Browse repository at this point
Copy the full SHA 932f4edView commit details -
Configuration menu - View commit details
-
Copy full SHA for a95b16a - Browse repository at this point
Copy the full SHA a95b16aView commit details -
Configuration menu - View commit details
-
Copy full SHA for e2d449a - Browse repository at this point
Copy the full SHA e2d449aView commit details -
Enable Debug Adapter Updates (#53)
* Get debug adapter to update when new versions are avaliable * Debug adapter download only happens if there's a new version avaliable * Use DebugAdapter.name() instead of string literals * Fix bug where some daps wouldn't update/install correctly * Clean up download adapter from github function * Add debug adapter caching * Add basic notification event to dap_store
Configuration menu - View commit details
-
Copy full SHA for 290c76d - Browse repository at this point
Copy the full SHA 290c76dView commit details
Commits on Oct 24, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 115f2eb - Browse repository at this point
Copy the full SHA 115f2ebView commit details -
Configuration menu - View commit details
-
Copy full SHA for 57668db - Browse repository at this point
Copy the full SHA 57668dbView commit details
Commits on Oct 26, 2024
-
Correctly refetch/invalidate stackframes/scopes/variables (#55)
* Correctly invalidate and refetch data * Fix show current stack frame after invalidating * Remove not used return value * Clean up * Don't send SelectedStackFrameChanged when id is still the same * Only update the active debug line if we got the editor
Configuration menu - View commit details
-
Copy full SHA for a45aa3d - Browse repository at this point
Copy the full SHA a45aa3dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 96871b4 - Browse repository at this point
Copy the full SHA 96871b4View commit details -
Configuration menu - View commit details
-
Copy full SHA for ddaf150 - Browse repository at this point
Copy the full SHA ddaf150View commit details
Commits on Oct 27, 2024
-
Show DAP status in activity bar (#54)
* Begin integrating languages with DAP * Add dap status type to activity indicator Co-authored-by: Remco Smits <djsmits12@gmail.com> * Show dap status to users * Change Status enum to use ServerStatus struct in activity indicator --------- Co-authored-by: Remco Smits <djsmits12@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for d279afa - Browse repository at this point
Copy the full SHA d279afaView commit details -
Allow users to configure
host
,port
andtimeout
for build in TC……P adapters (#56) * Remove space in cargo.toml * Add TCPHost for Javascript and PHP adapter * Allow falling back to first open port * Add some more docs to TCPHost * Fix cached binaries prevent from having multiple debug sessions for one adapters This was an issue, because we stored the port arg inside the DebugAdapterBinary which was cached so could not change anymore. Co-authored-by: Anthony Eid <hello@anthonyeid.me> * Add default setting for tcp timeout Co-Authored-By: Anthony Eid <56899983+Anthony-Eid@users.noreply.github.com> --------- Co-authored-by: Anthony Eid <hello@anthonyeid.me> Co-authored-by: Anthony Eid <56899983+Anthony-Eid@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for f7eb521 - Browse repository at this point
Copy the full SHA f7eb521View commit details -
Show users error notices when dap fails to start
Co-authored-by: Remco Smits <djsmits12@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for f6556c5 - Browse repository at this point
Copy the full SHA f6556c5View commit details -
Switch debugpy to use TCP instead of STDIO
Co-authored-by: Remco Smits <djsmits12@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0c647ae - Browse repository at this point
Copy the full SHA 0c647aeView commit details -
Fix dap update status not going away
Co-authored-by: Remco Smits <djsmits12@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for aa98752 - Browse repository at this point
Copy the full SHA aa98752View commit details -
Show debugger actions only during active sessions
Co-authored-by: Remco Smits <djsmits12@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 747ef3e - Browse repository at this point
Copy the full SHA 747ef3eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 15535d3 - Browse repository at this point
Copy the full SHA 15535d3View commit details
Commits on Oct 30, 2024
-
Configuration menu - View commit details
-
Copy full SHA for cd2b4a8 - Browse repository at this point
Copy the full SHA cd2b4a8View commit details
Commits on Nov 1, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 5efdaf3 - Browse repository at this point
Copy the full SHA 5efdaf3View commit details -
Add current working directory to adapter (#59)
* Add current working directory to adapter * Prio use resolve cwd
Configuration menu - View commit details
-
Copy full SHA for d226de3 - Browse repository at this point
Copy the full SHA d226de3View commit details -
Configuration menu - View commit details
-
Copy full SHA for d1ddbfc - Browse repository at this point
Copy the full SHA d1ddbfcView commit details -
Check if debug task cwd field is a valid path
If the path isn't valid the default cwd value is used (users worktree directory)
Configuration menu - View commit details
-
Copy full SHA for bb89c1d - Browse repository at this point
Copy the full SHA bb89c1dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 591f6cc - Browse repository at this point
Copy the full SHA 591f6ccView commit details
Commits on Nov 2, 2024
-
Implement Attach debugger + picker (#58)
* Rename StopDebugAdapters to ShutdownDebugAdapters * Remove debug config from install methods * Move requests methods to background executor * Wip attach with picker * Move find client to the first line of the method The client should always be there at this point. * Fix correctly determine when to restart While debugging an reverse request issue, the top level client did send terminated event with `restart: false` but we tried to restart the client resulting in the client never being cleaned up by us. Because before this change we always assumed if we got a json value we are going to restart the client, which is wrong. We no try to restart the client if: - restart arg is a boolean and its true - restart arg is a json value but no boolean * Clean up response to adapter * Fix clippy errors * WIP tasks * Simplified debug task schema This changes debug.json to look for adapter: adapter_name instead of and object when a user selects a debug adatper and fixes the default behavior of request (to launch) Co-authored-by: Remco Smits <djsmits12@gmail.com> * Make default and flatten work for request * Rename enum case * Remove dbg * Dismiss when candidate is not found * Add docs for why we update the process id on the config * Show error when `attach` request is selected but not supported --------- Co-authored-by: Anthony Eid <hello@anthonyeid.me>
Configuration menu - View commit details
-
Copy full SHA for 65cd774 - Browse repository at this point
Copy the full SHA 65cd774View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1b2871a - Browse repository at this point
Copy the full SHA 1b2871aView commit details
Commits on Nov 3, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 45c4aef - Browse repository at this point
Copy the full SHA 45c4aefView commit details
Commits on Nov 6, 2024
-
Get users python binary path based on
which
instead ofpython3
& ……pass shell_env to Adapters (#63) * Add ProjectEnvironment to Dap Store & use get users python3 path from which command * Pass shell env to debug adapters
Configuration menu - View commit details
-
Copy full SHA for 56df4fb - Browse repository at this point
Copy the full SHA 56df4fbView commit details -
Disable the ability to create debug tasks from tasks.json (#61)
This was done to simplify the process of setting up a debug task and improve task organization. This commit also improves parsing of debug.json so it's able to ignore misconfiguration debug tasks instead of failing and returning no configured tasks
Configuration menu - View commit details
-
Copy full SHA for 56f77c3 - Browse repository at this point
Copy the full SHA 56f77c3View commit details
Commits on Nov 7, 2024
-
Fix adapter completion not showing in debug.json
schemars seems to have a bug when generating schema for a struct with more than one flatten field. Only the first flatten field works correctly and the second one doesn't show up in the schema.
Configuration menu - View commit details
-
Copy full SHA for 9772573 - Browse repository at this point
Copy the full SHA 9772573View commit details -
Configuration menu - View commit details
-
Copy full SHA for bae6edb - Browse repository at this point
Copy the full SHA bae6edbView commit details
Commits on Nov 8, 2024
-
Go Adapter Implementation (#64)
* Go DAP WIP * Start work on getting go adapter working * Get beta version of go adapter working & fix breakpoint line msgs This adapter only works if a user has Go & delve in their PATH. It doesn't automatically download & updates itself because the official download process from the Delve docs would add delve to a user's PATH. I want to discuss with the Zed dev team & Remco if that is behavior we're ok with because typical downloads don't affect a user's PATH. This PR also fixes a bug where some breakpoint line numbers were incorrect when sending to active DAP servers.
Configuration menu - View commit details
-
Copy full SHA for 9e37b47 - Browse repository at this point
Copy the full SHA 9e37b47View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9781292 - Browse repository at this point
Copy the full SHA 9781292View commit details -
Configuration menu - View commit details
-
Copy full SHA for ffaaadf - Browse repository at this point
Copy the full SHA ffaaadfView commit details
Commits on Nov 10, 2024
-
Configuration menu - View commit details
-
Copy full SHA for fb5bee3 - Browse repository at this point
Copy the full SHA fb5bee3View commit details -
Configuration menu - View commit details
-
Copy full SHA for b728779 - Browse repository at this point
Copy the full SHA b728779View commit details -
Configuration menu - View commit details
-
Copy full SHA for 055ffc1 - Browse repository at this point
Copy the full SHA 055ffc1View commit details -
Allow users to toggle ignore breakpoints (#62)
* Add allow users to ignore breakpoints * Add different colors for both states * Add source name for breakpoints * Move ignore breakpoints to dap store * Change icon instead of color * Add action for ignore breakpoints for a client * Remove spacing * Fix compile error * Return task instead of detaching itself
Configuration menu - View commit details
-
Copy full SHA for c19c860 - Browse repository at this point
Copy the full SHA c19c860View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0976e85 - Browse repository at this point
Copy the full SHA 0976e85View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7cec577 - Browse repository at this point
Copy the full SHA 7cec577View commit details -
Configuration menu - View commit details
-
Copy full SHA for 68ee3c7 - Browse repository at this point
Copy the full SHA 68ee3c7View commit details -
Configuration menu - View commit details
-
Copy full SHA for b69d031 - Browse repository at this point
Copy the full SHA b69d031View commit details -
Configuration menu - View commit details
-
Copy full SHA for ba25aa2 - Browse repository at this point
Copy the full SHA ba25aa2View commit details -
Configuration menu - View commit details
-
Copy full SHA for aa5d51d - Browse repository at this point
Copy the full SHA aa5d51dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 964a6e8 - Browse repository at this point
Copy the full SHA 964a6e8View commit details -
I added this it fix the race issue with session exited without stopping on a breakpoint. Turns out the adapter was sending these events for other threads that where not visible.
Configuration menu - View commit details
-
Copy full SHA for c54454f - Browse repository at this point
Copy the full SHA c54454fView commit details -
Only clear the active debug line for the editor that belongs to the c…
…urrent debug line Also added a missing `cx.notify()` which fixes a delay when the line is removed visually
Configuration menu - View commit details
-
Copy full SHA for 15dd1ee - Browse repository at this point
Copy the full SHA 15dd1eeView commit details
Commits on Nov 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 81ca004 - Browse repository at this point
Copy the full SHA 81ca004View commit details -
Configuration menu - View commit details
-
Copy full SHA for 31e3e48 - Browse repository at this point
Copy the full SHA 31e3e48View commit details
Commits on Nov 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ce30dea - Browse repository at this point
Copy the full SHA ce30deaView commit details -
Fix debug client terminate bug where some highlights were not cleared
Co-authored-by: Remco Smits <djsmits12@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for ca80d0c - Browse repository at this point
Copy the full SHA ca80d0cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6f0e223 - Browse repository at this point
Copy the full SHA 6f0e223View commit details -
Configuration menu - View commit details
-
Copy full SHA for 80f775e - Browse repository at this point
Copy the full SHA 80f775eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 977fd87 - Browse repository at this point
Copy the full SHA 977fd87View commit details
Commits on Nov 13, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 23ccf08 - Browse repository at this point
Copy the full SHA 23ccf08View commit details -
Configuration menu - View commit details
-
Copy full SHA for ae0d08f - Browse repository at this point
Copy the full SHA ae0d08fView commit details -
Configuration menu - View commit details
-
Copy full SHA for d8f8140 - Browse repository at this point
Copy the full SHA d8f8140View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2c1f348 - Browse repository at this point
Copy the full SHA 2c1f348View commit details
Commits on Nov 15, 2024
-
Fix output that was produced before initial stop was not visible at f…
…irst stop (#57) * Fix log breakpoint output bug when hit before any breakpoints * Fix always push to output queue * Don't pop output queue We still want all the output in new threads * Fix clippy error --------- Co-authored-by: Remco Smits <djsmits12@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 3a77d7a - Browse repository at this point
Copy the full SHA 3a77d7aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 99bfc34 - Browse repository at this point
Copy the full SHA 99bfc34View commit details -
Configuration menu - View commit details
-
Copy full SHA for b6dc3ca - Browse repository at this point
Copy the full SHA b6dc3caView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0d84881 - Browse repository at this point
Copy the full SHA 0d84881View commit details
Commits on Nov 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 3aaee14 - Browse repository at this point
Copy the full SHA 3aaee14View commit details -
Configuration menu - View commit details
-
Copy full SHA for a3220dc - Browse repository at this point
Copy the full SHA a3220dcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7e01507 - Browse repository at this point
Copy the full SHA 7e01507View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8c72b99 - Browse repository at this point
Copy the full SHA 8c72b99View commit details -
This also fixes that we did not see the initial debug tasks defined in `initial_debug_tasks.json`. So new users should see at least these debug tasks the could run, without having to define them their selfs.
Configuration menu - View commit details
-
Copy full SHA for 008bd53 - Browse repository at this point
Copy the full SHA 008bd53View commit details
Commits on Nov 19, 2024
-
The php adapter hangs when you click to fast on the UI buttons, so waiting 15 seconds before the request timeout was reached is a bit to much. Because after the timeout you can still continue the debug session.
Configuration menu - View commit details
-
Copy full SHA for 8e738ba - Browse repository at this point
Copy the full SHA 8e738baView commit details
Commits on Nov 25, 2024
-
Collab: Sync breakpoints (#68)
* Sync breakpoints on toggle to other client * WIP Seperate local/remote in dap store * WIP initial breakpoints sync Co-Authored-By: Anthony Eid <56899983+Anthony-Eid@users.noreply.github.com> * Get zed to compile * Don't remove dap data when you unshare * Add breakpoints table migration * Update collab db when changing breakpoints * Store breakpoints inside collab db when you change them * Clean up * Fix incorrect clearing of breakpoints during collab sync * Get breakpoints to sync correctly on project join We now send SynchronizedBreakpoints within the JoinProjectResponse and use those breakpoints to initialize a remote DapStore. * Set breakpoints from proto method --------- Co-authored-by: Anthony Eid <56899983+Anthony-Eid@users.noreply.github.com> Co-authored-by: Anthony Eid <hello@anthonyeid.me>
Configuration menu - View commit details
-
Copy full SHA for 2c45c57 - Browse repository at this point
Copy the full SHA 2c45c57View commit details -
Configuration menu - View commit details
-
Copy full SHA for 046ff02 - Browse repository at this point
Copy the full SHA 046ff02View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5971d37 - Browse repository at this point
Copy the full SHA 5971d37View commit details
Commits on Nov 27, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 35a52a7 - Browse repository at this point
Copy the full SHA 35a52a7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6bc5679 - Browse repository at this point
Copy the full SHA 6bc5679View commit details -
Configuration menu - View commit details
-
Copy full SHA for df71b97 - Browse repository at this point
Copy the full SHA df71b97View commit details
Commits on Nov 28, 2024
-
Add gdb debug adapter implementation (#70)
* dap_adapters: add gdb * debug: Add debug zed with gdb task
Configuration menu - View commit details
-
Copy full SHA for 4068960 - Browse repository at this point
Copy the full SHA 4068960View commit details -
Disable gdb dap on non x86 platforms
Gdb doesn't run on Arm platforms so I'm disabling it to avoid users running into bugs. It will still work on intel macs and x86 devices
Configuration menu - View commit details
-
Copy full SHA for b8b65f7 - Browse repository at this point
Copy the full SHA b8b65f7View commit details -
Collab: Sync active debug line (#71)
* Add sync active debug line over collab * Remove unused downcast * Remove unused import
Configuration menu - View commit details
-
Copy full SHA for 386031e - Browse repository at this point
Copy the full SHA 386031eView commit details