Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debugger implementation #13433

Draft
wants to merge 432 commits into
base: main
Choose a base branch
from
Draft
This pull request is big! We’re only showing the most recent 250 commits.

Commits on Jul 31, 2024

  1. Fix use correct request to stop thread (#11)

    * Fix clippy
    
    * Remove increment request sequence (wrong while merging)
    
    * Send correct request to stop thread based on capabilities
    RemcoSmitsDev authored Jul 31, 2024
    Configuration menu
    Copy the full SHA
    aa257ec View commit details
    Browse the repository at this point in the history
  2. Act on capabilities when sending requests (#12)

    * Fix used wrong request args in set breakpoints request
    
    Some debug adapters depend on getting the exact data that you passed in `launch` or `attach` request.
    
    * Send correct request for stopping debug adapter
    
    I changed the name to be more in line with the request name. We now also send the correct request values on the `support_terminate_debuggee` and `support_terminate_debuggee` capabilities.
    
    * Send disconnect request for terminate threads if it does not support it
    
    * Only send configuration done request if its supported
    
    * Add disconnect icon
    
    * Only send step over request params when adapter supports it
    
    * Only send resume(continue) request params if adapter supports it
    
    * Step in only send request args if adapter supports it
    
    * Step out only send request args if adapter supports it
    
    * Step back only send request args if adapter supports it
    
    * Log error using `detach_and_log_err` instead of manually
    RemcoSmitsDev authored Jul 31, 2024
    Configuration menu
    Copy the full SHA
    1c98c1c View commit details
    Browse the repository at this point in the history
  3. Add terminate request

    RemcoSmitsDev committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    fc4d46e View commit details
    Browse the repository at this point in the history
  4. Make clippy pass

    RemcoSmitsDev committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    c99865b View commit details
    Browse the repository at this point in the history
  5. Remove unused crates

    RemcoSmitsDev committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    7ff1a08 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    a0123e8 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    a82d759 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2024

  1. Configuration menu
    Copy the full SHA
    e974dde View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    42aefb4 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ca84463 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9dfd2f5 View commit details
    Browse the repository at this point in the history
  5. Change breakpoint DS back so it uses buffer_id as a key

    I also made a new DS specifically for breakpoints that aren't part of any open buffers.
    It should be easier to serialize and deserialize breakpoints now.
    Anthony-Eid committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    8b63c1a View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2024

  1. Configuration menu
    Copy the full SHA
    d4904f9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0247fd6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    68158d3 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2024

  1. Configuration menu
    Copy the full SHA
    e24e5f7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b1d830c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5f4affd View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    f3cb4a4 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    4181c39 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    ef63ccf View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2024

  1. Configuration menu
    Copy the full SHA
    96bdeca View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    49dd57d View commit details
    Browse the repository at this point in the history
  3. Fix merge conflicts

    RemcoSmitsDev committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    f4af5af View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a4cc28f View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2024

  1. Handle case where Code action indicator interlaps with breakpoint

    Code action's that overlap with breakpoints will now show as red. Still need to
    add a code action to toggle a breakpoint & handle overlaps with code runners
    Anthony-Eid committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    c92ecc6 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2024

  1. Show a breakpoint on line with code action while code action symbol i…

    …s loading
    
    I also handle overlaps with code test buttons as well
    Anthony-Eid committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    1ad8ed7 View commit details
    Browse the repository at this point in the history
  2. Get project::has_active_debuggers to return true if a debugger is run…

    …ning instead of starting
    
    We shouldn't consider a debugger active until it's running because it may fail during it's starting phase.
    Also, this check is used determine if we should update a file's breakpoints when one is toggled.
    Anthony-Eid committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    111a0dc View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5a08fc2 View commit details
    Browse the repository at this point in the history
  4. Get breakpoints to display in the correct positions within multi buffers

    Remco Smits <djsmits12@gmail.com>
    Anthony-Eid committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    7d243ac View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    a4db59c View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    cb52082 View commit details
    Browse the repository at this point in the history
  7. Fix bug that caused a breakpoints to only remain persistent in one op…

    …en file when booting zed up
    Anthony-Eid committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    d3fe698 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    0f1738c View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2024

  1. Configuration menu
    Copy the full SHA
    30b59a6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fe58a70 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2024

  1. Show variables recursively (#16)

    * WIP Show variables in toggable list items
    
    * Use more unique element id so we can group variables by name and reference
    
    * Fix correct pass in listItem toggle value
    
    * Fix we did not set the current stack frame id
    
    * WIP start fetching variables recursively
    
    * Remove duplicated code for current stack frame id
    
    * Fetch all variables for each stack frame parallel
    
    * Fetch all variable on the same level parallel
    
    * Rename vars so its more clear
    
    * Refactor how we store thread data
    
    We now store the information in a better way so we could filter on it easier and faster.
    
    * Remove unused code
    
    * Use stack frame id as top level key instead of struct itself
    
    * Add has_children to scope thread entry
    
    * Fix allow switching current stack frame
    
    Also fixed building list entries twice right after each other
    
    * Show message when scope does not have variables
    
    * Remove scope if it does not have variables
    
    * Add allow collapsing scopes
    
    * Add allow collapsing variables
    
    * Add docs to determine collapsed variables
    
    * Allow collapsing variables and always show first scope variables
    
    * Correctly fix collapse variables
    
    * Fix clippy
    RemcoSmitsDev authored Aug 12, 2024
    Configuration menu
    Copy the full SHA
    5678469 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2024

  1. Configuration menu
    Copy the full SHA
    26e9843 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b561c68 View commit details
    Browse the repository at this point in the history
  3. Fix wrong value for always showing disclosure icon

    Oopss, after testing i did commit the wrong value.
    RemcoSmitsDev committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    9ea23b0 View commit details
    Browse the repository at this point in the history
  4. Remove debugger client when its terminated (#18)

    * Only terminate thread if it did not already end
    
    * Remove debug client when its terminated
    RemcoSmitsDev authored Aug 14, 2024
    Configuration menu
    Copy the full SHA
    9643e71 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    bb40689 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2024

  1. Breakpoint PR review edits

    Co-authored-by: Remco Smits <djsmits12@gmail.com>
    Anthony-Eid and RemcoSmitsDev committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    3a3f499 View commit details
    Browse the repository at this point in the history
  2. Set up ground work for debugger settings & save breakpoints setting

    Co-authored-by: Remco Smits <djsmits12@gmail.com>
    Anthony-Eid and RemcoSmitsDev committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    e9f0e93 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    da1fdd2 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2024

  1. Lazy fetch variables (#19)

    * Lazy fetch
    
    * Remove unused code
    
    * Clean up fetch nested variable
    
    * Include scope id for variable id to be more unique
    
    * Clean up not needed get_mut function calls
    RemcoSmitsDev authored Aug 18, 2024
    Configuration menu
    Copy the full SHA
    11b2bc1 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2024

  1. Configuration menu
    Copy the full SHA
    1ac97d2 View commit details
    Browse the repository at this point in the history
  2. Fix typo

    RemcoSmitsDev committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    db8b8be View commit details
    Browse the repository at this point in the history
  3. Add todo to fix bug & bug information

    Co-authored-by: Remco Smits <djsmits12@gmail.com>
    Anthony-Eid and RemcoSmitsDev committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    fb169af View commit details
    Browse the repository at this point in the history
  4. Merge debugger into breakpoints

    Co-authored-by: Remco Smits <djsmits12@gmail.com>
    Anthony-Eid and RemcoSmitsDev committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    5c45e45 View commit details
    Browse the repository at this point in the history
  5. Merge pull request #13 from Anthony-Eid/breakpoints

    Make breakpoints persistent across Zed sessions
    Anthony-Eid authored Aug 21, 2024
    Configuration menu
    Copy the full SHA
    2843a36 View commit details
    Browse the repository at this point in the history
  6. Fix typos

    RemcoSmitsDev committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    7885da1 View commit details
    Browse the repository at this point in the history
  7. Fix failing test

    RemcoSmitsDev committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    3c98e89 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    651c31c View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    bbb449c View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2024

  1. Configuration menu
    Copy the full SHA
    149116e View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2024

  1. Add debug icon to toggle debug panel (#23)

    * Add debug icon to toggle debug panel
    
    * Add setting to wether to show the debug button
    
    * Fix clippy
    RemcoSmitsDev authored Aug 23, 2024
    Configuration menu
    Copy the full SHA
    f3e7129 View commit details
    Browse the repository at this point in the history
  2. Remove default methods

    RemcoSmitsDev committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    9bcd03b View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2024

  1. Configuration menu
    Copy the full SHA
    618d81a View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2024

  1. Improve clear highlights performance (#25)

    * Only clear highlights op open tabs
    
    This much better so we don't have to open each path of each stack frame in each thread.
    
    * Don't open the same file twice for clearing thread highlights
    RemcoSmitsDev authored Aug 25, 2024
    Configuration menu
    Copy the full SHA
    5a301fc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    31b27e1 View commit details
    Browse the repository at this point in the history
  3. Remove duplicated content code for debugger settings (#27)

    Refactored this because its being refactored inside: zed-industries#16744
    RemcoSmitsDev authored Aug 25, 2024
    Configuration menu
    Copy the full SHA
    199b665 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    045f927 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2024

  1. Debugger elements (#29)

    Anthony-Eid authored Aug 26, 2024
    Configuration menu
    Copy the full SHA
    2b504b3 View commit details
    Browse the repository at this point in the history
  2. Debugger console (#30)

    * Create debugger console
    
    * Get console to output console messages during output events
    
    * Use match expression in handle_output_event
    
    * Move debug console code to it's own file console
    Anthony-Eid authored Aug 26, 2024
    Configuration menu
    Copy the full SHA
    008b6b5 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    921d0c5 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2024

  1. Configuration menu
    Copy the full SHA
    3ac4d1e View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2024

  1. Configuration menu
    Copy the full SHA
    243bd4b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fc4078f View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2024

  1. Configuration menu
    Copy the full SHA
    4cf735b View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2024

  1. Make stepping granularity configurable (#33)

    This commit also changes the default granularity to line, before this was statement but most editors have line as the default.
    RemcoSmitsDev authored Sep 1, 2024
    Configuration menu
    Copy the full SHA
    83cc452 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2024

  1. Show warning when session exited without hitting any breakpoint (#31)

    * Show warning when session did not stop but exited
    
    * Fix code was not formatted any more
    
    * Fix clippy
    RemcoSmitsDev authored Sep 3, 2024
    Configuration menu
    Copy the full SHA
    7b7a475 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2024

  1. Allow setting variable value (#34)

    * Wip render set variable value editor
    
    * Remove unused subscriptions
    
    * Set current variable value & select all when setting value
    
    * Send set variable request
    
    * Rename tread entry to VariableListEntry
    
    * WIP allow setting variables for nested structures
    
    * Refactor & rename vars on thread state to be only the ids
    
    * Fix we did not correct notify the right context when updating variable list
    
    * Clean open entries when debugger stops
    
    * Use SetExpression if adapter supports it when setting value
    
    * Refetch scope variables after setting value
    
    This commit also reworks how we store scopes & variables
    
    * Remove debug code
    
    * Make Clippy happy
    
    * Rename variable
    
    * Change order for variable id
    
    * Allow cancelling set value using escape key
    RemcoSmitsDev authored Sep 7, 2024
    Configuration menu
    Copy the full SHA
    b009832 View commit details
    Browse the repository at this point in the history
  2. Merge main

    RemcoSmitsDev committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    ac2aa79 View commit details
    Browse the repository at this point in the history
  3. Fix Clippy errors

    RemcoSmitsDev committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    edf4e53 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2024

  1. Move breakpoint & debug client code to dap_store (#36)

    * Move breakpoint and client code to dap store
    
    This also changes how we sync breakpoints. Now we just update the dap store model instead of having a RWlock.
    
    The goal is to prepare for making inlay hints for debugging work.
    
    * Remove debug code
    
    * Remove unused method
    
    * Fix don't grow the amount tasks for sending all the breakpoints
    
    * Partially implement terminate clients when app quits
    
    * Sync open breakpoints to closed breakpoints when buffer is closed
    
    * Call terminate request also for not already started clients
    
    * Fix missing import
    
    * Remove not needed read_with call
    RemcoSmitsDev authored Sep 8, 2024
    Configuration menu
    Copy the full SHA
    b00d63b View commit details
    Browse the repository at this point in the history
  2. Remove commented code

    RemcoSmitsDev committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    b2927a0 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    dc5d0f4 View commit details
    Browse the repository at this point in the history
  4. Make Debug tasks easier for a user to config

    * Start setting up new debug task format
    
    * Set up blueprint for converting from debug task to regular task
    
    * Create debug adapter trait
    
    * Get debug.json schema to json lsp to show users hints
    
    * Start debugger task refactor to enable easier debugger setup
    
    * Get python adapter to work within task.json
    
    co-authored-by: Piotr <piotr@zed.dev>
    
    * Start work on getting Php Debug adapter working
    
    * Make debug adapter trait work with async functions
    
    Fix CICD spell check & clippy warnings
    
    Co-authored-by: Remco Smits <djsmits12@gmail.com>
    
    ---------
    
    Co-authored-by: Piotr <piotr@zed.dev>
    Co-authored-by: Remco Smits <djsmits12@gmail.com>
    3 people committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    1e99694 View commit details
    Browse the repository at this point in the history
  5. Remove unused dep

    RemcoSmitsDev committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    0e6042e View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    165e058 View commit details
    Browse the repository at this point in the history
  7. Remove debug code

    RemcoSmitsDev committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    09c195e View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2024

  1. Configuration menu
    Copy the full SHA
    5d07ab0 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2024

  1. Add support for LLDB

    osiewicz committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    3683920 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4990242 View commit details
    Browse the repository at this point in the history
  3. Change breakpoint position from multi_buffer::Anchor -> text::Anchor

    This fixes a crash that happened when placing a breakpoint within a multi buffer
    where it's excerpt_id != 1.
    
    Co-authored-by: Remco Smits <djsmits12@gmail.com>
    Anthony-Eid and RemcoSmitsDev committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    5a0c7d2 View commit details
    Browse the repository at this point in the history
  4. Change open_breakpoint's BTree to use project_path as it's key

    This is the first step of merging open/close breakpoints into
    one data structure.
    
    Co-authored-by: Remco Smits <djsmits12@gmail.com>
    Anthony-Eid and RemcoSmitsDev committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    0f5e5ea View commit details
    Browse the repository at this point in the history
  5. Merge open/close breakpoints into one data structure

    This is done by making breakpoint.position field optional and
    adding a cached_position field too. I also added dap_store to
    buffer_store and got buffer_store to initialize breakpoints
    when a new buffer is opened. Fixing a bug where some breakpoints
    wouldn't appear within multi buffers
    Anthony-Eid committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    e6049f9 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    3184ba1 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    18fb45f View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2024

  1. Remove unused deps

    RemcoSmitsDev committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    a4ce446 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ab6f334 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7a6f9d9 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3fac36b View commit details
    Browse the repository at this point in the history
  5. Get .zed/debug.json to resolve debug tasks properly

    Co-authored-by: Piotr <piotr@zed.dev>
    Anthony-Eid and osiewicz committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    8a835bc View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    ed6da4a View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    571d99c View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2024

  1. Correctly shutdown adapter (#37)

    * Kill adapter and close channels
    
    * Always try to terminate the debug adapter
    
    * Remove TODO
    
    * Always allow allow the user to restart if capability allows it
    
    Co-Authored-By: Anthony Eid <56899983+Anthony-Eid@users.noreply.github.com>
    
    * Drop tasks
    
    Co-Authored-By: Anthony Eid <56899983+Anthony-Eid@users.noreply.github.com>
    
    * WIP fix hang
    
    * Remove debug code
    
    * clean up
    
    ---------
    
    Co-authored-by: Anthony Eid <56899983+Anthony-Eid@users.noreply.github.com>
    RemcoSmitsDev and Anthony-Eid authored Sep 13, 2024
    Configuration menu
    Copy the full SHA
    4405ae2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9b82278 View commit details
    Browse the repository at this point in the history
  3. Fix typo

    RemcoSmitsDev committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    559173e View commit details
    Browse the repository at this point in the history
  4. Move Request, Response, Event types to dap-types repo

    This also changes the concept of passing the receiver inside the request to make sure we handle all the requests in the right order.
    
    Now we have another peace of state that keeps track of the current requests, and when request comes in we move the receiver to the pending requests state and handle the request as we did before.
    RemcoSmitsDev committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    3985963 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2024

  1. Configuration menu
    Copy the full SHA
    4694de8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    56943e2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    716a817 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    8cdb1fb View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2024

  1. Configuration menu
    Copy the full SHA
    621d181 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e7f7fb7 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    142a6de View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. Configuration menu
    Copy the full SHA
    c1ab059 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c3a7787 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c883166 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2024

  1. Refactor: Move types to the correct place and move specific request c…

    …ode to the dapstore (#39)
    
    * Make dap store global
    
    * Partially move initialize & capability code to dap store
    
    * Reuse shutdown for shutdown clients
    
    * Rename merge_capabilities
    
    * Correctly fallback to current thread id for checking to skip event
    
    * Move mthod
    
    * Move terminate threads to dap store
    
    * Move disconnect and restart to dap store
    
    * Update dap-types to the correct version
    
    This includes the capabilities::merge method
    
    * Change dap store to WeakModel in debug panels
    
    * Make clippy happy
    
    * Move pause thread to dap store
    
    * WIP refactor out thread state and capbilities
    
    * Move update thread status to debug panel method
    
    * Remove double notify
    
    * Move continue thread to dap store
    
    * Change WeakModel dapStore to Model dapStore
    
    * Move step over to dap store
    
    * Move step in to dap store
    
    * Move step out to dap store
    
    * Remove step back
    
    we don't support this yet
    
    * Move threadState type to debugPanel
    
    * Change to background task
    
    * Fix panic when debugSession stopped
    
    * Remove capabilities when debug client stops
    
    * Add missing notify
    
    * Remove drain that causes panic
    
    * Remove Arc<DebugAdapterClient> from debug_panel_item instead use the id
    
    * Reset stack_frame_list to prevent crash
    
    * Refactor ThreadState to model to prevent recursion dependency in variable_list
    
    * WIP
    
    * WIP move set_variable_value and get_variables to dap store
    
    * Remove unused method
    
    * Fix correctly insert updated variables
    
    Before this changes you would see the variables * scopes. Because it did not insert the the variables per scope.
    
    * Correctly update current stack frame on variable list
    
    * Only allow building variable list entries for current stack frame
    
    * Make toggle variables & scopes work again
    
    * Fix clippy
    
    * Pass around id instead of entire client
    
    * Move set breakpoints to dap store
    
    * Show thread status again in tooltip text
    
    * Move stack frames and scope requests to dap store
    
    * Move terminate request to dap store
    
    * Remove gap that is not doing anything
    
    * Add retain back to remove also threads that belong to the client
    
    * Add debug kind back to tab content
    RemcoSmitsDev authored Sep 21, 2024
    Configuration menu
    Copy the full SHA
    9612b60 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    278699f View commit details
    Browse the repository at this point in the history
  3. Make CI pass

    RemcoSmitsDev committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    f1f1426 View commit details
    Browse the repository at this point in the history
  4. Remove unused dep

    RemcoSmitsDev committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    c26a8f1 View commit details
    Browse the repository at this point in the history
  5. Make test pass again

    RemcoSmitsDev committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    4ddb65b View commit details
    Browse the repository at this point in the history
  6. Make clippy pass

    RemcoSmitsDev committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    8b96ac8 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2024

  1. Configuration menu
    Copy the full SHA
    7dec58c View commit details
    Browse the repository at this point in the history
  2. Merge pull request #38 from Anthony-Eid/breakpoint-context-menu

    Breakpoint Context Menu & Log Breakpoints
    Anthony-Eid authored Sep 22, 2024
    Configuration menu
    Copy the full SHA
    231b5a9 View commit details
    Browse the repository at this point in the history
  3. Move all the debug panel actions to the workspace (#41)

    This PR moves out all the actions from the **debug_panel_item** to the **workspace** which allows people to use these actions inside their key binds.
    
    I also had to remove the debug_panel dependency inside the debug_panel_item, because we hit a `"cannot update debug_panel while it is already being updated"` panic. So instead of updating the thread status inside the **debug_panel** we now do this inside the **debug_panel_item** to prevent this panic. 
    
    I also move the actions to its own debugger namespace, so it's more clear what the actions are for.
    
    The new actions can now also be used for key binds:
    ```
    debugger: start
    debugger: continue
    debugger: step into
    debugger: step over
    debugger: step out
    debugger: restart
    debugger: stop
    debugger: pause
    ```
    
    /cc @Anthony-Eid We now can have key binds for debugger actions.
    RemcoSmitsDev authored Sep 22, 2024
    Configuration menu
    Copy the full SHA
    a3dff43 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9016a03 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. Remove useless method

    RemcoSmitsDev committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    ce77773 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. Configuration menu
    Copy the full SHA
    9bc08f9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3b3ac85 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    29918d9 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. Show current debug line when you reopen a buffer (#42)

    * Only include dap store if editor.mode is FULL
    
    * Move go to stack frame to debug_panel_item
    
    * Notify dap_store when updating active breakpoints location
    
    * Fix clippyyyy
    
    * Show active debug line when you reopen a buffer
    
    * Remove uncommented code
    
    This is not needed anymore, we already clear the highlights when thread exited
    
    * Make clippy happy
    
    * Fix todo for removing highlights on exited event
    RemcoSmitsDev authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    bfddc63 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    171ddfb View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. Configuration menu
    Copy the full SHA
    1914cef View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2024

  1. Debug console (#43)

    * Use buffer settings for font, size etc.
    
    * Trim end of message
    
    * By default send the output values to the output editor
    
    * WIP send evaluate request
    
    * Rename variable
    
    * Add result to console from evaluate response
    
    * Remove not needed arc
    
    * Remove store capabilities on variable_list
    
    * Specify the capacity for the task vec
    
    * Add placeholder
    
    * WIP add completion provider for existing variables
    
    * Add value to auto completion label
    
    * Make todo for debugger
    
    * Specify the capacity of the vec's
    
    * Make clippy happy
    
    * Remove not needed notifies and add missing one
    
    * WIP move scopes and variables to variable_list
    
    * Rename configuration done method
    
    * Add support for adapter completions and manual variable completions
    
    * Move type to variabel_list
    
    * Change update to read
    
    * Show debug panel when debug session stops
    
    Co-Authored-By: Anthony Eid <56899983+Anthony-Eid@users.noreply.github.com>
    Co-Authored-By: Mikayla Maki <mikayla.c.maki@gmail.com>
    
    * Also use scope reference to determine to which where the set value editor should display
    
    * Refetch existing variables after
    
    * Rebuild entries after refetching the variables
    
    ---------
    
    Co-authored-by: Anthony Eid <56899983+Anthony-Eid@users.noreply.github.com>
    Co-authored-by: Mikayla Maki <mikayla.c.maki@gmail.com>
    3 people authored Oct 4, 2024
    Configuration menu
    Copy the full SHA
    842bf02 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'main' into debugger

    Co-authored-by: Anthony Eid <hello@anthonyeid.me>
    RemcoSmitsDev and Anthony-Eid committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    55c6570 View commit details
    Browse the repository at this point in the history
  3. Fix current debug line highlight did not work

    Co-authored-by: Anthony Eid <hello@anthonyeid.me>
    RemcoSmitsDev and Anthony-Eid committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    6b4ebac View commit details
    Browse the repository at this point in the history
  4. Breakpoint prompt editor (#44)

    * Create basic breakpoint prompt editor structure
    
    * Get breakpoint prompt to properly render
    
    * Fix bug where toggle breakpoint failed to work
    
    This bug occurs when a breakpoint anchor position is moved from the begining
    of a line. This causes dap_store.breakpoint hashmap to fail to properly get
    the correct element, thus toggling the wrong breakpoint.
    
    The fix to this bug is passing a breakpoint anchor to an editor's display map
    and to the render breakpoint function. Instead of creating a new anchor when
    clicking on a breakpoint icon, zed will use the breakpoint anchor passed to
    the display map.
    
    In the case of using toggle breakpoint action, zed will iterate through all
    breakpoints in that buffer to check if any are on the cursor's line number,
    then use anchor if found. Otherwise, zed creates a new anchor.
    
    * Fix bug where breakpoint icon overlaps with other icons
    
    This bug happened when an icon {code action | code runner} was rendered on the same line of a breakpoint
    where that breakpoint's anchor was not at the start of the line
    
    * Get breakpoint prompt to add log breakpoint's correctly
    
    * Clean up breakpoint prompt UI & allow editting of log messages
    
    ---------
    
    Co-authored-by: Remco Smits <djsmits12@gmail.com>
    Anthony-Eid and RemcoSmitsDev authored Oct 4, 2024
    Configuration menu
    Copy the full SHA
    93af1bf View commit details
    Browse the repository at this point in the history
  5. Format file

    RemcoSmitsDev committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    3c301c3 View commit details
    Browse the repository at this point in the history
  6. Remove unused crates

    RemcoSmitsDev committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    f9b045b View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2024

  1. Configuration menu
    Copy the full SHA
    c2ed56a View commit details
    Browse the repository at this point in the history
  2. Module list (#46)

    RemcoSmitsDev authored Oct 5, 2024
    Configuration menu
    Copy the full SHA
    8c0a7b1 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2024

  1. Configuration menu
    Copy the full SHA
    f76b7c9 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2024

  1. Move stack frame list to its own view (#47)

    * WIP Move stack frame list to own module
    
    * Add missing notify
    
    * Remove some more duplicated state for the current stack frame
    
    * Clear highlights when stack frame has changed
    
    * Fix go to stack frame again
    RemcoSmitsDev authored Oct 7, 2024
    Configuration menu
    Copy the full SHA
    3b545a7 View commit details
    Browse the repository at this point in the history
  2. Merge main

    RemcoSmitsDev committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    984cb68 View commit details
    Browse the repository at this point in the history
  3. Merge main

    RemcoSmitsDev committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    ac0ba07 View commit details
    Browse the repository at this point in the history
  4. DapAdapter Updates (#40)

    * Pass http client to dap store
    
    * Set up DapAdapterDelegate to use for DAP binary fetches
    
    * WIP to get debug adapters to use zed directory for installs
    
    * Get debugpy automatic download working
    
    * Change DapAdapter fetch_or_install to return a Result
    
    * Add node_runtime to dap delegate
    
    Co-authored-by: Remco Smits <djsmits12@gmail.com>
    
    * Create dap_adapter crate & move language dap adapter code to that crate
    
    This is the first phase of dap::client refactor to organize debug adapters with zed lsp adapters.
    Eventually dap::client will have a TransportParams pass to it instead of an adapter, and adapters
    will handle custom debug events.
    
    Co-authored-by: Remco Smits <djsmits12@gmail.com>
    
    * Move language specific dap adapter code to their own files
    
    * Move DebugAdapter member out of ClientDebugAdapter struct
    
    This change was done to make dap::client more in line with zed's lsp::client, it might be reverted depending
    on if this solution is cleaner or not.
    
    * Get php debug adapter to auto download when needed
    
    * Get adapter_path argument to work with auto download dap adapters
    
    ---------
    
    Co-authored-by: Remco Smits <djsmits12@gmail.com>
    Anthony-Eid and RemcoSmitsDev authored Oct 7, 2024
    Configuration menu
    Copy the full SHA
    187d909 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2024

  1. Make ci pass

    RemcoSmitsDev committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    00b6fdc View commit details
    Browse the repository at this point in the history
  2. Remove unused dep

    RemcoSmitsDev committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    eedd865 View commit details
    Browse the repository at this point in the history
  3. Remove new lines from variable list value

    This fixes a display issue, for javascript expression values.
    RemcoSmitsDev committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    08935b2 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    91926cd View commit details
    Browse the repository at this point in the history
  5. Add missing license

    RemcoSmitsDev committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    5f1de1a View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2024

  1. Make start debugging request work again

    This also fixes an issue that you could not add your own initialize_args for non custom adapters
    RemcoSmitsDev committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    171c742 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a728f9e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8a4f677 View commit details
    Browse the repository at this point in the history
  4. Cleanup adapters code and add javascript adapter (#48)

    * Clean up how adapters install and fetch their binary
    
    Before this was in one method, which was hard to read and doing to many things.
    
    * Add javascript debug adapter
    
    * Get node binary from node_runtime
    
    * Undo remove request args for lldb
    
    * Remove initialize value for now
    
    * Remove default values
    
    * Fix did not compile javascript
    
    * Fix php did not build
    RemcoSmitsDev authored Oct 9, 2024
    Configuration menu
    Copy the full SHA
    7e2c138 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2024

  1. Configuration menu
    Copy the full SHA
    554a402 View commit details
    Browse the repository at this point in the history
  2. Add support for custom adapters

    Also simplify the DebugAdapterBInary struct
    RemcoSmitsDev committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    177ae28 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2024

  1. Configuration menu
    Copy the full SHA
    b1d24a0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5bb7f24 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2024

  1. Fix missing thread_state status update when client was terminated

    Before this change the debug panel was still in the running state, which is/was wrong. So updating the status to Ended, will update the UI to an correct state.
    RemcoSmitsDev committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    222cd4b View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. Fix clippy

    RemcoSmitsDev committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    b46b8aa View commit details
    Browse the repository at this point in the history
  2. Add loaded sources (#49)

    * Remove not needed notify
    
    * Add loaded sources list
    
    * Remove not needed double nested div.child()
    
    * Remove not needed block
    
    * Fix todo for updating loaded source
    RemcoSmitsDev authored Oct 14, 2024
    Configuration menu
    Copy the full SHA
    5758f66 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f5dc117 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c65ed1c View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    13afc37 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2024

  1. Configuration menu
    Copy the full SHA
    3a6f2ad View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2024

  1. Debug terminal (#50)

    * Make program optional in debug task format
    
    * Remove default config for skipFile JavaScript debugger
    
    * Add Debug case to TerminalKind
    
    * Don't allow serializing debug terminals
    
    * Add respond method so we can send response back for reverse requests
    
    * Implement run in terminal reverse request
    
    * Move client calls to dap store
    
    This commit also fixes an issue with not sending a response for the `StartDebugging` reverse request.
    
    * Make clippy happy
    RemcoSmitsDev authored Oct 17, 2024
    Configuration menu
    Copy the full SHA
    1c1e34b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fdea7d9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    afe228f View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2024

  1. Configuration menu
    Copy the full SHA
    2e028a7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6735cfa View commit details
    Browse the repository at this point in the history
  3. Move how we connect to an debug adpater to the transport layer (#52)

    * Move how we connect to an debug adpater to the transport layer
    
    This PR cleans up how we connect to a debug adapter.
    Previously, this was done inside the debug adapter implementation.
    
    While reviewing the debugger RPC log view PR,
    I noticed that we could simplify the transport/client code,
    making it easier to attach handlers for logging RPC messages.
    
    * Remove not needed async block
    
    * Change hardcoded delay before connecting to tcp adapter to timeout approach
    
    Co-Authored-By: Anthony Eid <hello@anthonyeid.me>
    
    ---------
    
    Co-authored-by: Anthony Eid <hello@anthonyeid.me>
    RemcoSmitsDev and Anthony-Eid authored Oct 20, 2024
    Configuration menu
    Copy the full SHA
    fc78c40 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    211fd50 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    30a4c84 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2024

  1. Implement logging for debug adapter clients (#45)

    * Implement RPC logging for debug adapter clients
    
    * Implement server logs for debugger servers
    
    * This cleans up the way we pass through the input and output readers for logging. So not each debug adapters have to map the AdapterLogIO fields.  I also removed some specific when has logs from the client, because the client is not responsible for that.  Removed an not needed/duplicated dependency  Fix formatting & clippy
    
    This cleans up the way we pass through the input and output readers for logging. So not each debug adapters have to map the AdapterLogIO fields.
    
    I also removed some specific when has logs from the client, because the client is not responsible for that.
    
    Removed an not needed/duplicated dependency
    
    Fix formatting & clippy
    
    * Implement `has_adapter_logs` for each transport impl
    
    * Make adapter stdout logging work
    
    * Add conditional render for adapter log back
    
    * Oops forgot to pipe the output
    
    * Always enable rpc messages
    
    Previously, RPC messages were only stored when explicitly enabled, which occurred after the client was already running. This approach prevented debugging of requests sent during the initial connection period. By always enabling RPC messages, we ensure that all requests, including those during the connection phase, are captured and available for debugging purposes.
    
    This could help use debug when someone has troble getting a debug starting. This improvement could be particularly helpful in debugging scenarios where users encounter issues during the initial connection or startup phase of their debugging sessions.
    
    ---------
    
    Co-authored-by: Remco Smits <djsmits12@gmail.com>
    Co-authored-by: Anthony Eid <hello@anthonyeid.me>
    3 people authored Oct 21, 2024
    Configuration menu
    Copy the full SHA
    43ea3b4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6f973bd View commit details
    Browse the repository at this point in the history
  3. Remove unused dep

    RemcoSmitsDev committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    b426ff6 View commit details
    Browse the repository at this point in the history
  4. Add missing license

    RemcoSmitsDev committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    ffc0582 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2024

  1. Configuration menu
    Copy the full SHA
    8baa280 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2024

  1. Clean up DAP install code (#51)

    * Clean up dap adapter install_binary functions 
    
    * Get lldb-dap working when on macos
    
    * Add release tag to name of downloaded DAPs
    
    * Check if adapter is already installed before installing one
    Anthony-Eid authored Oct 23, 2024
    Configuration menu
    Copy the full SHA
    61daad2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    932f4ed View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a95b16a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e2d449a View commit details
    Browse the repository at this point in the history
  5. Enable Debug Adapter Updates (#53)

    * Get debug adapter to update when new versions are avaliable
    
    * Debug adapter download only happens if there's a new version avaliable
    
    * Use DebugAdapter.name() instead of string literals
    
    * Fix bug where some daps wouldn't update/install correctly
    
    * Clean up download adapter from github function
    
    * Add debug adapter caching
    
    * Add basic notification event to dap_store
    Anthony-Eid authored Oct 23, 2024
    Configuration menu
    Copy the full SHA
    290c76d View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2024

  1. Configuration menu
    Copy the full SHA
    115f2eb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    57668db View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2024

  1. Correctly refetch/invalidate stackframes/scopes/variables (#55)

    * Correctly invalidate and refetch data
    
    * Fix show current stack frame after invalidating
    
    * Remove not used return value
    
    * Clean up
    
    * Don't send SelectedStackFrameChanged when id is still the same
    
    * Only update the active debug line if we got the editor
    RemcoSmitsDev authored Oct 26, 2024
    Configuration menu
    Copy the full SHA
    a45aa3d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    96871b4 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ddaf150 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2024

  1. Show DAP status in activity bar (#54)

    * Begin integrating languages with DAP
    
    * Add dap status type to activity indicator
    
    Co-authored-by: Remco Smits <djsmits12@gmail.com>
    
    * Show dap status to users
    
    * Change Status enum to use ServerStatus struct in activity indicator
    
    ---------
    
    Co-authored-by: Remco Smits <djsmits12@gmail.com>
    Anthony-Eid and RemcoSmitsDev authored Oct 27, 2024
    Configuration menu
    Copy the full SHA
    d279afa View commit details
    Browse the repository at this point in the history
  2. Allow users to configure host, port and timeout for build in TC…

    …P adapters (#56)
    
    * Remove space in cargo.toml
    
    * Add TCPHost for Javascript and PHP adapter
    
    * Allow falling back to first open port
    
    * Add some more docs to TCPHost
    
    * Fix cached binaries prevent from having multiple debug sessions for one adapters
    
    This was an issue, because we stored the port arg inside the DebugAdapterBinary which was cached so could not change anymore.
    
    Co-authored-by: Anthony Eid <hello@anthonyeid.me>
    
    * Add default setting for tcp timeout
    
    Co-Authored-By: Anthony Eid <56899983+Anthony-Eid@users.noreply.github.com>
    
    ---------
    
    Co-authored-by: Anthony Eid <hello@anthonyeid.me>
    Co-authored-by: Anthony Eid <56899983+Anthony-Eid@users.noreply.github.com>
    3 people authored Oct 27, 2024
    Configuration menu
    Copy the full SHA
    f7eb521 View commit details
    Browse the repository at this point in the history
  3. Show users error notices when dap fails to start

    Co-authored-by: Remco Smits <djsmits12@gmail.com>
    Anthony-Eid and RemcoSmitsDev committed Oct 27, 2024
    Configuration menu
    Copy the full SHA
    f6556c5 View commit details
    Browse the repository at this point in the history
  4. Switch debugpy to use TCP instead of STDIO

    Co-authored-by: Remco Smits <djsmits12@gmail.com>
    Anthony-Eid and RemcoSmitsDev committed Oct 27, 2024
    Configuration menu
    Copy the full SHA
    0c647ae View commit details
    Browse the repository at this point in the history
  5. Fix dap update status not going away

    Co-authored-by: Remco Smits <djsmits12@gmail.com>
    Anthony-Eid and RemcoSmitsDev committed Oct 27, 2024
    Configuration menu
    Copy the full SHA
    aa98752 View commit details
    Browse the repository at this point in the history
  6. Show debugger actions only during active sessions

    Co-authored-by: Remco Smits <djsmits12@gmail.com>
    Anthony-Eid and RemcoSmitsDev committed Oct 27, 2024
    Configuration menu
    Copy the full SHA
    747ef3e View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    15535d3 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2024

  1. Configuration menu
    Copy the full SHA
    cd2b4a8 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2024

  1. Configuration menu
    Copy the full SHA
    5efdaf3 View commit details
    Browse the repository at this point in the history
  2. Add current working directory to adapter (#59)

    * Add current working directory to adapter
    
    * Prio use resolve cwd
    RemcoSmitsDev authored Nov 1, 2024
    Configuration menu
    Copy the full SHA
    d226de3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d1ddbfc View commit details
    Browse the repository at this point in the history
  4. Check if debug task cwd field is a valid path

    If the path isn't valid the default cwd value is used (users worktree directory)
    Anthony-Eid authored and RemcoSmitsDev committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    bb89c1d View commit details
    Browse the repository at this point in the history
  5. Fix linux clippy error

    RemcoSmitsDev committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    591f6cc View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2024

  1. Implement Attach debugger + picker (#58)

    * Rename StopDebugAdapters to ShutdownDebugAdapters
    
    * Remove debug config from install methods
    
    * Move requests methods to background executor
    
    * Wip attach with picker
    
    * Move find client to the first line of the method
    
    The client should always be there at this point.
    
    * Fix correctly determine when to restart
    
    While debugging an reverse request issue, the top level client did send terminated event with `restart: false` but we tried to restart the client resulting in the client never being cleaned up by us.
    
    Because before this change we always assumed if we got a json value we are going to restart the client, which is wrong.
    
    We no try to restart the client if:
    - restart arg is a boolean and its true
    - restart arg is a json value but no boolean
    
    * Clean up response to adapter
    
    * Fix clippy errors
    
    * WIP tasks
    
    * Simplified debug task schema
    
    This changes debug.json to look for adapter: adapter_name instead of
    and object when a user selects a debug adatper and fixes the default
    behavior of request (to launch)
    
    Co-authored-by: Remco Smits <djsmits12@gmail.com>
    
    * Make default and flatten work for request
    
    * Rename enum case
    
    * Remove dbg
    
    * Dismiss when candidate is not found
    
    * Add docs for why we update the process id on the config
    
    * Show error when `attach` request is selected but not supported
    
    ---------
    
    Co-authored-by: Anthony Eid <hello@anthonyeid.me>
    RemcoSmitsDev and Anthony-Eid authored Nov 2, 2024
    Configuration menu
    Copy the full SHA
    65cd774 View commit details
    Browse the repository at this point in the history
  2. Fix failing test

    RemcoSmitsDev committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    1b2871a View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2024

  1. Configuration menu
    Copy the full SHA
    45c4aef View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2024

  1. Get users python binary path based on which instead of python3 & …

    …pass shell_env to Adapters (#63)
    
    * Add ProjectEnvironment to Dap Store & use get users python3 path from which command
    
    * Pass shell env to debug adapters
    Anthony-Eid authored Nov 6, 2024
    Configuration menu
    Copy the full SHA
    56df4fb View commit details
    Browse the repository at this point in the history
  2. Disable the ability to create debug tasks from tasks.json (#61)

    This was done to simplify the process of setting up a debug task and improve task organization.
    This commit also improves parsing of debug.json so it's able to ignore misconfiguration debug tasks
    instead of failing and returning no configured tasks
    Anthony-Eid authored Nov 6, 2024
    Configuration menu
    Copy the full SHA
    56f77c3 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2024

  1. Fix adapter completion not showing in debug.json

    schemars seems to have a bug when generating schema for a struct with more than
    one flatten field. Only the first flatten field works correctly and the second
    one doesn't show up in the schema.
    Anthony-Eid committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    9772573 View commit details
    Browse the repository at this point in the history
  2. Fix failing unit test

    Anthony-Eid committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    bae6edb View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2024

  1. Go Adapter Implementation (#64)

    * Go DAP WIP
    
    * Start work on getting go adapter working
    
    * Get beta version of go adapter working & fix breakpoint line msgs
    
    This adapter only works if a user has Go & delve in their PATH. It doesn't automatically download & updates itself because the official download process from the Delve docs would add delve to a user's PATH. I want to discuss with the Zed dev team & Remco if that is behavior we're ok with because typical downloads don't affect a user's PATH.
    
    This PR also fixes a bug where some breakpoint line numbers were incorrect when sending to active DAP servers.
    Anthony-Eid authored Nov 8, 2024
    Configuration menu
    Copy the full SHA
    9e37b47 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9781292 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ffaaadf View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2024

  1. Configuration menu
    Copy the full SHA
    fb5bee3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b728779 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    055ffc1 View commit details
    Browse the repository at this point in the history
  4. Allow users to toggle ignore breakpoints (#62)

    * Add allow users to ignore breakpoints
    
    * Add different colors for both states
    
    * Add source name for breakpoints
    
    * Move ignore breakpoints to dap store
    
    * Change icon instead of color
    
    * Add action for ignore breakpoints for a client
    
    * Remove spacing
    
    * Fix compile error
    
    * Return task instead of detaching itself
    RemcoSmitsDev authored Nov 10, 2024
    Configuration menu
    Copy the full SHA
    c19c860 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    0976e85 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    7cec577 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    68ee3c7 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    b69d031 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    ba25aa2 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    aa5d51d View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    964a6e8 View commit details
    Browse the repository at this point in the history
  12. Remove not needed notify

    I added this it fix the race issue with session exited without stopping on a breakpoint. Turns out the adapter was sending these events for other threads that where not visible.
    RemcoSmitsDev committed Nov 10, 2024
    Configuration menu
    Copy the full SHA
    c54454f View commit details
    Browse the repository at this point in the history
  13. Only clear the active debug line for the editor that belongs to the c…

    …urrent debug line
    
    Also added a missing `cx.notify()` which fixes a delay when the line is removed visually
    RemcoSmitsDev committed Nov 10, 2024
    Configuration menu
    Copy the full SHA
    15dd1ee View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2024

  1. Fix clippy error

    RemcoSmitsDev committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    81ca004 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    31e3e48 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2024

  1. Configuration menu
    Copy the full SHA
    ce30dea View commit details
    Browse the repository at this point in the history
  2. Fix debug client terminate bug where some highlights were not cleared

    Co-authored-by: Remco Smits <djsmits12@gmail.com>
    Anthony-Eid and RemcoSmitsDev committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    ca80d0c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6f0e223 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    80f775e View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    977fd87 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2024

  1. Configuration menu
    Copy the full SHA
    23ccf08 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ae0d08f View commit details
    Browse the repository at this point in the history
  3. Fix compile error

    RemcoSmitsDev committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    d8f8140 View commit details
    Browse the repository at this point in the history
  4. Refine spacing

    RemcoSmitsDev committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    2c1f348 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2024

  1. Fix output that was produced before initial stop was not visible at f…

    …irst stop (#57)
    
    * Fix log breakpoint output bug when hit before any breakpoints
    
    * Fix always push to output queue
    
    * Don't pop output queue
    
    We still want all the output in new threads
    
    * Fix clippy error
    
    ---------
    
    Co-authored-by: Remco Smits <djsmits12@gmail.com>
    Anthony-Eid and RemcoSmitsDev authored Nov 15, 2024
    Configuration menu
    Copy the full SHA
    3a77d7a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    99bfc34 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b6dc3ca View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    0d84881 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2024

  1. Configuration menu
    Copy the full SHA
    3aaee14 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a3220dc View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7e01507 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    8c72b99 View commit details
    Browse the repository at this point in the history
  5. Add debug task file watcher

    This also fixes that we did not see the initial debug tasks defined in `initial_debug_tasks.json`. So new users should see at least these debug tasks the could run, without having to define them their selfs.
    RemcoSmitsDev committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    008bd53 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2024

  1. Reduce request timeout

    The php adapter hangs when you click to fast on the UI buttons, so waiting 15 seconds before the request timeout was reached is a bit to much. Because after the timeout you can still continue the debug session.
    RemcoSmitsDev committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    8e738ba View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2024

  1. Collab: Sync breakpoints (#68)

    * Sync breakpoints on toggle to other client
    
    * WIP Seperate local/remote in dap store
    
    * WIP initial breakpoints sync
    
    Co-Authored-By: Anthony Eid <56899983+Anthony-Eid@users.noreply.github.com>
    
    * Get zed to compile
    
    * Don't remove dap data when you unshare
    
    * Add breakpoints table migration
    
    * Update collab db when changing breakpoints
    
    * Store breakpoints inside collab db when you change them
    
    * Clean up
    
    * Fix incorrect clearing of breakpoints during collab sync
    
    * Get breakpoints to sync correctly on project join
    
    We now send SynchronizedBreakpoints within the JoinProjectResponse
    and use those breakpoints to initialize a remote DapStore.
    
    * Set breakpoints from proto method
    
    ---------
    
    Co-authored-by: Anthony Eid <56899983+Anthony-Eid@users.noreply.github.com>
    Co-authored-by: Anthony Eid <hello@anthonyeid.me>
    3 people authored Nov 25, 2024
    Configuration menu
    Copy the full SHA
    2c45c57 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    046ff02 View commit details
    Browse the repository at this point in the history
  3. Fix failing tests

    RemcoSmitsDev committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    5971d37 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2024

  1. Configuration menu
    Copy the full SHA
    35a52a7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6bc5679 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    df71b97 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2024

  1. Add gdb debug adapter implementation (#70)

    * dap_adapters: add gdb
    
    * debug: Add debug zed with gdb task
    jansol authored Nov 28, 2024
    Configuration menu
    Copy the full SHA
    4068960 View commit details
    Browse the repository at this point in the history
  2. Disable gdb dap on non x86 platforms

    Gdb doesn't run on Arm platforms so I'm disabling it to avoid users
    running into bugs. It will still work on intel macs and x86 devices
    Anthony-Eid committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    b8b65f7 View commit details
    Browse the repository at this point in the history
  3. Collab: Sync active debug line (#71)

    * Add sync active debug line over collab
    
    * Remove unused downcast
    
    * Remove unused import
    RemcoSmitsDev authored Nov 28, 2024
    Configuration menu
    Copy the full SHA
    386031e View commit details
    Browse the repository at this point in the history